Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cli): Support hotswap for Docker Image Lambda function #18302

Closed
1 of 2 tasks
tmokmss opened this issue Jan 7, 2022 · 6 comments · Fixed by #18319
Closed
1 of 2 tasks

(cli): Support hotswap for Docker Image Lambda function #18302

tmokmss opened this issue Jan 7, 2022 · 6 comments · Fixed by #18319
Assignees
@skinny85
Labels
effort/medium Medium work item – several days of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI

Comments

@tmokmss
Copy link
Contributor

tmokmss commented Jan 7, 2022 •
edited

Description

Support hotswap for DockerImageFunction code.

Use Case

Just like normal lambda functions, we can quickly update DockerImageFunction code.

Proposed Solution

tbw

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@tmokmss tmokmss added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 7, 2022
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Jan 7, 2022
@skinny85
Copy link
Contributor

skinny85 commented Jan 8, 2022

Thanks for opening the issue @tmokmss! That is indeed a great use case for hotswapping that I totally missed!

@skinny85 skinny85 added effort/medium Medium work item – several days of effort p1 feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 8, 2022
@skinny85 skinny85 assigned skinny85 and unassigned rix0rrr Jan 8, 2022
@tmokmss
Copy link
Contributor Author

tmokmss commented Jan 8, 2022

Hi @skinny85, I'm happy to implement this feature but please let me know if you're already working on it. Thanks!

@skinny85
Copy link
Contributor

skinny85 commented Jan 8, 2022

That is great to hear @tmokmss!

Fair word of warning: this will probably be a more complex change than an average Construct Library PR. For reference, take a look at a few PRs that implemented hotswapping for various resources (here's the original Lambda one, here's StepFunctions State Machines, here's CodeBuild Projects).

Let me know if you'd still be interested in giving this a shot, and if you are, we are happy to leave this one for you 🙂.

Thanks,
Adam

@tmokmss tmokmss mentioned this issue Jan 8, 2022
Merged
@tmokmss
Copy link
Contributor Author

tmokmss commented Jan 8, 2022

@skinny85 Thank you for the kind offer! I submitted a PR above. (btw it now also supports InlineCode hotswap for feature completeness 👍 .)

Although I checked basic behavior in my local env, please teach me if I'm missing any consideration. I'll add unit tests later.

@skinny85
Copy link
Contributor

That's awesome @tmokmss, thanks so much for doing that! I'll check out the PR today.

@mergify mergify bot closed this as completed in #18319 Jan 14, 2022
mergify bot pushed a commit that referenced this issue Jan 14, 2022
@tmokmss
feat(cli): support hotswapping Lambda functions that use Docker images (
6b553b7 
#18319)

closes #18302

We must just update `ImageUri` with the new ECR image url.

PR for `InlineCode` hotswap: #18408
 
`----`

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
@tmokmss @TikiTDO
feat(cli): support hotswapping Lambda functions that use Docker images (
9744c77 
aws#18319)

closes aws#18302

We must just update `ImageUri` with the new ECR image url.

PR for `InlineCode` hotswap: aws#18408
 
`----`

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
effort/medium Medium work item – several days of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): support hotswapping Lambda functions that use Docker images tmokmss/aws-cdk
3 participants
@skinny85 @rix0rrr @tmokmss