Closed
Description
Description
Let's print out the total time it takes for cdk deploy
to finish, including when a deployment happens through cdk watch
.
This will allows us to brag more easily about how quickly hotswapping works 😃.
Use Case
Showing the speedup hotswap deployments offer.
Proposed Solution
Print out the time it takes for deployment to finish in the CDK CLI.
Other information
Print out the total time
Acknowledge
- I may be able to implement this feature requestThis feature might incur a breaking change
Activity
cdk watch
demo content aws-samples/aws-cdk-intro-workshop#390kaizencc commentedon Dec 29, 2021
I actually feel like this is reinventing the wheel a little bit, specifically for
cdk deploy
. We can easily callyarn cdk deploy
ortime cdk deploy
to get the same functionality. The only time where we can't do this is forcdk watch
, since it's not one-shot.I thought we might just do this for
cdk watch
only and add a time stamp wrapper around this:aws-cdk/packages/aws-cdk/lib/cdk-toolkit.ts
Line 302 in dee732d
Happy to do it for
cdk deploy
if you feel otherwise but I feel like the use case is only forcdk watch
.skinny85 commentedon Dec 29, 2021
I agree it's not great if we simply write out the total time. So why don't we spice things up a little bit? 😃
What if we divided the different phases of deploy, and printed out the time for each of them? For example, the time to
synth
the Cloud Assembly immediately jumps out to me as being interesting.So, the output would be something like:
Thoughts on this idea?
misterjoshua commentedon Dec 29, 2021
In this vein: I'd appreciate a performance tracing mode for synthesis because I find it difficult to tell which parts of my cdk app (probably bundling assets, but which?) are slowing my synth down.
cdk deploy
steps take #18230feat(cli): show how long `cdk deploy` steps take (#18230)
github-actions commentedon Jan 4, 2022
Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.
feat(cli): show how long `cdk deploy` steps take (aws#18230)