feat(ec2): add support for al2022 and amzn2 with kernel 5.x #18117
Conversation
|
|
github-actions
bot
added
the
@aws-cdk/aws-ec2
|
@njlynch I'd really appreciate your feedback when you get a chance. I still think this needs to be refactored. I'm not really happy with cleanliness of this PR. Just let me know what you think and I'll follow your lead. In the meantime, I've converted this PR to a draft. |
|
Also, I'm planning on updating |
There was a problem hiding this comment.
I think it looks good.
Re: a refactoring of sorts. I could potentially see creating an AmazonLinux2022Image class with less properties, but I'm not sure that's the right model. I think what you have makes as good sense as any a natural evolution of the existing model.
Co-authored-by: Nick Lynch <nlynch@amazon.com>
|
@njlynch let me know if you'd like to see more integration tests or other tests in general. Thanks! |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR is aimed to expand CDK ability to support `al2022` and `amzn2` with kernel 5.x ``` "/aws/service/ami-amazon-linux-latest/al2022-ami-kernel-5.10-arm64" "/aws/service/ami-amazon-linux-latest/al2022-ami-minimal-kernel-5.10-arm64" "/aws/service/ami-amazon-linux-latest/amzn-ami-hvm-x86_64-ebs" "/aws/service/ami-amazon-linux-latest/amzn-ami-hvm-x86_64-gp2" "/aws/service/ami-amazon-linux-latest/amzn-ami-hvm-x86_64-s3" "/aws/service/ami-amazon-linux-latest/amzn-ami-minimal-hvm-x86_64-s3" "/aws/service/ami-amazon-linux-latest/amzn2-ami-hvm-arm64-gp2" "/aws/service/ami-amazon-linux-latest/amzn2-ami-hvm-x86_64-ebs" "/aws/service/ami-amazon-linux-latest/amzn2-ami-hvm-x86_64-gp2" "/aws/service/ami-amazon-linux-latest/amzn2-ami-kernel-5.10-hvm-x86_64-ebs" "/aws/service/ami-amazon-linux-latest/al2022-ami-kernel-5.10-x86_64" "/aws/service/ami-amazon-linux-latest/al2022-ami-minimal-kernel-5.10-x86_64" "/aws/service/ami-amazon-linux-latest/amzn-ami-minimal-hvm-x86_64-ebs" "/aws/service/ami-amazon-linux-latest/amzn-ami-minimal-pv-x86_64-ebs" "/aws/service/ami-amazon-linux-latest/amzn-ami-minimal-pv-x86_64-s3" "/aws/service/ami-amazon-linux-latest/amzn-ami-pv-x86_64-ebs" "/aws/service/ami-amazon-linux-latest/amzn-ami-pv-x86_64-s3" "/aws/service/ami-amazon-linux-latest/amzn2-ami-kernel-5.10-hvm-arm64-gp2" "/aws/service/ami-amazon-linux-latest/amzn2-ami-kernel-5.10-hvm-x86_64-gp2" "/aws/service/ami-amazon-linux-latest/amzn2-ami-minimal-hvm-arm64-ebs" "/aws/service/ami-amazon-linux-latest/amzn2-ami-minimal-hvm-x86_64-ebs" ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR is aimed to expand CDK ability to support
al2022andamzn2with kernel 5.xBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license