Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ecr): setting imageScanningConfiguration to false does nothing on existing repository #18078

Merged
merged 2 commits into from Mar 18, 2022
Merged

fix(ecr): setting imageScanningConfiguration to false does nothing on existing repository #18078

merged 2 commits into from Mar 18, 2022

Conversation

peterwoodworth
Copy link
Contributor

fixes #18077

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 17, 2021

@github-actions github-actions bot added the @aws-cdk/aws-ecr Related to Amazon Elastic Container Registry label Dec 17, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 17, 2021
@peterwoodworth
Copy link
Contributor Author

Will push successful integ tests today

madeline-k
madeline-k approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am always a little bit nervous about changes that change the generated template with no changes to CDK app code. But in this case it seems necessary. This will fix an upgrade scenario that is currently broken. And, this should not cause anyone to have their stacks in a broken state after upgrade and cdk deploy.

Thanks, @peterwoodworth!

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr rix0rrr added bug This issue is a bug. p2 and removed @aws-cdk/aws-ecr Related to Amazon Elastic Container Registry contribution/core This is a PR that came from AWS. labels Mar 4, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 4, 2022
@peterwoodworth peterwoodworth force-pushed the peterwoodworth/ecrScanOnPushFix branch from 4cc6b9d to 2de17ee Compare March 17, 2022 23:52
@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 78bc870 into master Mar 18, 2022
@mergify mergify bot deleted the peterwoodworth/ecrScanOnPushFix branch March 18, 2022 13:33
@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 2f47dd6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madeline-k madeline-k madeline-k approved these changes

Assignees

@madeline-k madeline-k

Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(ecr): setting imageScanOnPush to false doesn't update Repository after first being set to true
4 participants
@peterwoodworth @aws-cdk-automation @madeline-k @rix0rrr