Skip to content

(cli): no message indicates that a hotswap happened #17778

Closed
@eladb

Description

@eladb
Contributor

Description

When using watch or --swap and a hotswap occurs, I expect the CLI to tell me that a hotswap actually happened. Otherwise it seems like no-op.

Use Case

Since our deployment process is quite verbose already, and indicates when resources are provisioned, I'd expect a hotswap to also be displayed as a message.

Here's an example output:

Detected file changes during deployment. Invoking 'cdk deploy' again
👾 bundle » bundle:foo.lambda | esbuild --bundle src/foo.lambda.ts --target="node14" --platform="node" --outfile="assets/foo.lambda/index.js" --external:aws-sdk

  assets/foo.lambda/index.js  559b

⚠️ The --hotswap flag deliberately introduces CloudFormation drift to speed up deployments
⚠️ It should only be used for development - never use it for your production Stacks!
my-stack-dev: deploying...
[0%] start: Publishing 258d20bfa0b25ae5baec07ea31bd444fb2ceaadbbc3e210cfbf6c14326d911b9:current
[100%] success: Published 258d20bfa0b25ae5baec07ea31bd444fb2ceaadbbc3e210cfbf6c14326d911b9:current

 ✅  my-stack-dev

Stack ARN:
arn:aws:cloudformation:us-east-1:585695036304:stack/my-stack-dev/9807ac00-5200-11ec-98f7-0e39c015f87d

As you can see, the asset publishing is printed, but then then it just shows the stack name without any indication that the AWS Lambda code was hotswapped.

Proposed Solution

Print something like:

Hotswapping AWS Lambda code bla bla bla

Other information

No response

Acknowledge

  • I may be able to implement this feature request
    This feature might incur a breaking change

Activity

added
feature-requestA feature should be added or improved.
needs-triageThis issue or PR still needs to be triaged.
on Nov 30, 2021
skinny85

skinny85 commented on Dec 1, 2021

@skinny85
Contributor

Great idea!

added
effort/mediumMedium work item – several days of effort
and removed
needs-triageThis issue or PR still needs to be triaged.
on Dec 1, 2021
removed their assignment
on Dec 1, 2021
added a commit that references this issue on Dec 17, 2021
e828c22
github-actions

github-actions commented on Dec 17, 2021

@github-actions
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

added a commit that references this issue on Feb 21, 2022
d681d8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    effort/mediumMedium work item – several days of effortfeature-requestA feature should be added or improved.p2package/toolsRelated to AWS CDK Tools or CLI

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @skinny85@rix0rrr@eladb

      Issue actions

        (cli): no message indicates that a hotswap happened · Issue #17778 · aws/aws-cdk