Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda-nodejs): add sourcesContent in BundlingOptions #17280

Merged
merged 8 commits into from Nov 4, 2021

Conversation

suds-sky
Copy link
Contributor

@suds-sky suds-sky commented Nov 2, 2021

Support excluding sourcesContent from esbuild generated source map

Closes #17256


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 2, 2021

@suds-sky suds-sky changed the title feat(nodejsfunction): sourcesContent in BundlingOptions feat(lambda-nodejs): sourcesContent in BundlingOptions Nov 3, 2021
@suds-sky suds-sky changed the title feat(lambda-nodejs): sourcesContent in BundlingOptions feat(nodejsfunction): sourcesContent in BundlingOptions Nov 3, 2021
@suds-sky
Copy link
Contributor Author

suds-sky commented Nov 3, 2021

@nija-at / @peterwoodworth Can you please check this. Tx.

@jogold
Copy link
Contributor

jogold commented Nov 3, 2021

@suds-sky thanks for the PR.

Can you update the test here to include this new option ?

test('esbuild bundling with esbuild options', () => {
Bundling.bundle({
entry,

and the doc here https://github.com/aws/aws-cdk/tree/master/packages/%40aws-cdk/aws-lambda-nodejs#configuring-esbuild

+ feat(nodejsfunction) -> feat(lambda-nodejs)

@suds-sky suds-sky changed the title feat(nodejsfunction): sourcesContent in BundlingOptions feat(lambda-nodejs): sourcesContent in BundlingOptions Nov 3, 2021
Co-authored-by: Jonathan Goldwasser <jogold@users.noreply.github.com>
@jogold
Copy link
Contributor

jogold commented Nov 3, 2021

@nija-at LGTM

@suds-sky
Copy link
Contributor Author

suds-sky commented Nov 4, 2021

Thanks @jogold taking a look at this PR. Is there anything else I have to do from my side to get this merged and released.

@jogold
Copy link
Contributor

jogold commented Nov 4, 2021

Is there anything else I have to do from my side to get this merged and released.

No, the PR is fine and should be approved when someone from the CDK team has time to have a look at it.

Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution!

@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@peterwoodworth peterwoodworth changed the title feat(lambda-nodejs): sourcesContent in BundlingOptions feat(lambda-nodejs): add sourcesContent in BundlingOptions Nov 4, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 126ef25
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ea56e69 into aws:master Nov 4, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@suds-sky suds-sky deleted the esbuild-sources-content-bundling branch November 4, 2021 20:46
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Support excluding sourcesContent from `esbuild` generated source map 

Closes aws#17256

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@aws-cdk/aws-lambda-nodejs: Esbuild bundling option to disable sourcesContent
5 participants