New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda-nodejs): add sourcesContent in BundlingOptions #17280
Conversation
@nija-at / @peterwoodworth Can you please check this. Tx. |
@suds-sky thanks for the PR. Can you update the test here to include this new option ? aws-cdk/packages/@aws-cdk/aws-lambda-nodejs/test/bundling.test.ts Lines 182 to 184 in 30e96da
and the doc here https://github.com/aws/aws-cdk/tree/master/packages/%40aws-cdk/aws-lambda-nodejs#configuring-esbuild + |
…' into esbuild-sources-content-bundling
Co-authored-by: Jonathan Goldwasser <jogold@users.noreply.github.com>
@nija-at LGTM |
Thanks @jogold taking a look at this PR. Is there anything else I have to do from my side to get this merged and released. |
No, the PR is fine and should be approved when someone from the CDK team has time to have a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the contribution!
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Support excluding sourcesContent from `esbuild` generated source map Closes aws#17256 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Support excluding sourcesContent from
esbuild
generated source mapCloses #17256
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license