Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docdb): add the ability to exclude characters when generating passwords #17262

Merged
merged 4 commits into from Nov 1, 2021
Merged

feat(docdb): add the ability to exclude characters when generating passwords #17262

merged 4 commits into from Nov 1, 2021

Conversation

jumic
Copy link
Contributor

@jumic jumic commented Nov 1, 2021

Add property excludeCharaters to provide the ability to exclude characters when generating passwords in DocumentDB.

Requested in #15732.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 1, 2021

@github-actions github-actions bot added the @aws-cdk/aws-docdb Related to Amazon DocumentDB label Nov 1, 2021
@skinny85 skinny85 mentioned this pull request Nov 1, 2021
Closed
skinny85
skinny85 previously requested changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jumic! One tiny change in the test please.

packages/@aws-cdk/aws-docdb/test/cluster.test.ts Outdated Show resolved Hide resolved
@jumic @skinny85
optimize test case
f372f90 
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
@mergify mergify bot dismissed skinny85’s stale review November 1, 2021 18:37

Pull request has been modified.

@jumic jumic requested a review from skinny85 November 1, 2021 18:42
@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 36fd32e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 135f7d3 into aws:master Nov 1, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 mentioned this pull request Nov 5, 2021
Closed
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@jumic @TikiTDO
feat(docdb): add the ability to exclude characters when generating pa…
ab9c8e4 
…sswords (aws#17262)

Add property `excludeCharaters` to provide the ability to exclude characters when generating passwords in DocumentDB.

Requested in aws#15732.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-docdb Related to Amazon DocumentDB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jumic @aws-cdk-automation @skinny85