@aws-cdk/aws-lambda-nodejs: Esbuild bundling option to disable sourcesContent

[suds-sky]

Description

With the NodeJsFunction construct, We have observed that the source code is included as part of the source maps. For production builds, We do not need this as we are not going to debug the lambda.

Use Case

For production lambdas, it is desirable to omit the source code in source maps generated by esbuild through NodeJsFunction construct

Proposed Solution

In esbuild, there is an option we can set to disable this to not to include the source code as per esbuild docs -https://esbuild.github.io/api/#sources-content

We can add a property (sourcesContent) to BundlingOptions type and allow the function to enable/disable the inclusion of sourcesContent into the source map generated.

Other information

No response

Acknowledge

• I may be able to implement this feature request
• This feature might incur a breaking change

[peterwoodworth]

Thanks for submitting this issue, contributions are welcome!

I think you know what you need to do if you want to contribute, but I'll share what I've found on a quick look for visibility :)

Like you said, we'll want to add a prop to BundlingOptions

aws-cdk/packages/@aws-cdk/aws-lambda-nodejs/lib/types.ts

Line 6 in 9c094ae

export interface BundlingOptions {

These end up getting passed here

aws-cdk/packages/@aws-cdk/aws-lambda-nodejs/lib/function.ts

Lines 106 to 113 in 9c094ae

	code: Bundling.bundle({
	...props.bundling ?? {},
	entry,
	runtime,
	architecture,
	depsLockFilePath,
	projectRoot,
	}),

And ultimately I think we'll want to add something here

aws-cdk/packages/@aws-cdk/aws-lambda-nodejs/lib/bundling.ts

Lines 186 to 204 in 9c094ae

	const esbuildCommand: string[] = [
	options.esbuildRunner,
	'--bundle', `"${pathJoin(options.inputDir, relativeEntryPath)}"`,
	`--target=${this.props.target ?? toTarget(this.props.runtime)}`,
	'--platform=node',
	`--outfile="${pathJoin(options.outputDir, 'index.js')}"`,
	...this.props.minify ? ['--minify'] : [],
	...sourceMapEnabled ? [`--sourcemap${sourceMapValue}`] : [],
	...this.externals.map(external => `--external:${external}`),
	...loaders.map(([ext, name]) => `--loader:${ext}=${name}`),
	...defines.map(([key, value]) => `--define:${key}=${JSON.stringify(value)}`),
	...this.props.logLevel ? [`--log-level=${this.props.logLevel}`] : [],
	...this.props.keepNames ? ['--keep-names'] : [],
	...this.relativeTsconfigPath ? [`--tsconfig=${pathJoin(options.inputDir, this.relativeTsconfigPath)}`] : [],
	...this.props.metafile ? [`--metafile=${pathJoin(options.outputDir, 'index.meta.json')}`] : [],
	...this.props.banner ? [`--banner:js=${JSON.stringify(this.props.banner)}`] : [],
	...this.props.footer ? [`--footer:js=${JSON.stringify(this.props.footer)}`] : [],
	...this.props.charset ? [`--charset=${this.props.charset}`] : [],
	];

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.