feat(iot-actions): add the action to put CloudWatch Logs

[yamatatsu]

I'm trying to implement aws-iot L2 Constructs.

This PR is one of steps after following PR:

• feat(iot): add the TopicRule L2 construct #16681 (comment)

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[yamatatsu]

I wonder about new actions.CloudwatchLogsAction(logGroup) constructor that which is better to implement to need property logGroup or not.

now:

new actions.CloudwatchLogsAction(logGroup)

Or we can implement to create logs in constructor if the property not be given as following:

new actions.CloudwatchLogsAction()

[skinny85]

I wonder about new actions.CloudwatchLogsAction(logGroup) constructor that which is better to implement to need property logGroup or not.

now:

new actions.CloudwatchLogsAction(logGroup)

Or we can implement to create logs in constructor if the property not be given as following:

new actions.CloudwatchLogsAction()

Let's start with the first one. It's simpler, and if we ever want to make logGroup optional later, we can - it will be a backwards-compatible change.

[yamatatsu]

@skinny85
Thank you for your reply! You've made me feel more confident 😀

[yamatatsu]

@madeline-k
This is ready to be reviewed now!

[skinny85]

Looks great, as always @yamatatsu! A few tiny comments before we merge this in 🙂.

Pull request has been modified.

[skinny85]

One last change needed. I'll do it myself though 😉.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

[skinny85]

Awesome stuff as always @yamatatsu!

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 8265df4
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).