Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cfnspec): cloudformation spec v46.0.0 #17223

Merged
merged 14 commits into from Nov 4, 2021
Merged

feat(cfnspec): cloudformation spec v46.0.0 #17223

merged 14 commits into from Nov 4, 2021

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Oct 28, 2021 •
edited

No description provided.

@gitpod-io
Copy link

gitpod-io bot commented Oct 28, 2021

@aws-cdk-automation aws-cdk-automation added pr-linter/exempt-test The PR linter will not require test changes pr/auto-approve Notifies the GH action to auto-approve this PR labels Oct 28, 2021
github-actions[bot]
github-actions bot previously approved these changes Oct 29, 2021
View reviewed changes
@madeline-k
Copy link
Contributor

The build is failing in a new module: aws-panorama. The generated code for the new module had a few issues:

  1. It depends on ^26.0.22 of jest which is not present in the yarn.lock. This was easy to fix, just check out the branch and run a yarn install.
  2. Build error: lib/index.ts:2:15 - error TS2307: Cannot find module './aws-panorama.generated' or its corresponding type declarations. I fixed this by modifying the index.ts file to export ./panorama.generated instead. The file is actually called panorama.generated.ts not aws-panorama.generated.ts. So there is some bug in the code gen for that.
  3. Warning: lib/panorama.generated.ts:550:1 - warning JSII5: The type "constructs.Construct" is exposed in the public API of this module. Therefore, the module "constructs" must also be defined under "peerDependencies". This will be auto-corrected unless --no-fix-peer-dependencies was specified. Fix: added "constructs": "^3.3.69" to peer deps and regular deps in package.json

Applied the same 3 fixes to aws-rekognition and aws-wisdom as well.

@mergify mergify bot dismissed github-actions’s stale review October 29, 2021 19:37

Pull request has been modified.

@madeline-k
Copy link
Contributor

ec2 build is failing now:

@aws-cdk/aws-ec2: error: [awslint:resource-attribute:@aws-cdk/aws-ec2.NetworkAclEntry.networkAclEntryId] resources must represent all cloudformation attributes as attribute properties. "@attribute ATTR[,ATTR]" can be used to tag non-standard attribute names. missing property: networkAclEntryId
@aws-cdk/aws-ec2: Error: /codebuild/output/src753637668/src/github.com/aws/aws-cdk/tools/@aws-cdk/cdk-build-tools/bin/cdk-awslint exited with error code 1

@madeline-k
Copy link
Contributor

fixed above, now getting:

error: [awslint:from-method:@aws-cdk/aws-ec2.NetworkAclEntry] resource should have at least one "fromXxx" static method or "fromXxxAttributes"

github-actions[bot]
github-actions bot previously approved these changes Oct 29, 2021
View reviewed changes
@mergify mergify bot dismissed github-actions’s stale review October 29, 2021 21:34

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes Oct 29, 2021
View reviewed changes
@mergify mergify bot dismissed github-actions’s stale review October 29, 2021 22:02

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes Oct 29, 2021
View reviewed changes
@mergify mergify bot dismissed github-actions’s stale review October 29, 2021 22:40

Pull request has been modified.

@madeline-k
Copy link
Contributor

secrets manager now failing because it does not have a default RemovalPolicy for the L2 Secret construct. Error:

[Default/Secret/Resource] 'AWS::SecretsManager::Secret' is a stateful resource type, and you must specify a Removal Policy for it. Call 'resource.applyRemovalPolicy()'.

This is because SecretsManager::Secret was recently added to the list of Stateful resources in https://github.com/aws-cloudformation/cfn-lint

github-actions[bot]
github-actions bot previously approved these changes Oct 29, 2021
View reviewed changes
@mergify mergify bot dismissed github-actions’s stale review October 29, 2021 22:58

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes Oct 29, 2021
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Oct 29, 2021
View reviewed changes
@mergify mergify bot dismissed github-actions’s stale review October 29, 2021 23:57

Pull request has been modified.

@PatMyron PatMyron mentioned this pull request Nov 1, 2021
Merged
@iliapolo iliapolo mentioned this pull request Nov 1, 2021
Merged
@pahud pahud mentioned this pull request Nov 2, 2021
Closed
2 tasks
github-actions[bot]
github-actions bot previously approved these changes Nov 3, 2021
View reviewed changes
@mergify mergify bot dismissed github-actions’s stale review November 3, 2021 09:03

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes Nov 3, 2021
View reviewed changes
@mergify mergify bot dismissed github-actions’s stale review November 3, 2021 19:41

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes Nov 3, 2021
View reviewed changes
@mergify mergify bot dismissed github-actions’s stale review November 3, 2021 23:54

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes Nov 4, 2021
View reviewed changes
@mergify mergify bot dismissed github-actions’s stale review November 4, 2021 10:38

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c51f955
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d9f7b58 into master Nov 4, 2021
@mergify mergify bot deleted the bump-cfnspec/v46.0.0 branch November 4, 2021 11:38
@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ayush987goyal ayush987goyal mentioned this pull request Nov 5, 2021
Merged
mergify bot pushed a commit that referenced this pull request Nov 5, 2021
@ayush987goyal
feat(cfnspec): cloudformation spec v47.0.0 (#17350)
ea71b4e 
Generated by running `scripts/bump-cfnspec.sh`. Wanted to speed up the additions required for #17290 .

Feel free to close if this is supposed to be created by a bot like #17223 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
iliapolo pushed a commit that referenced this pull request Nov 7, 2021
@ayush987goyal @iliapolo
feat(cfnspec): cloudformation spec v47.0.0 (#17350)
98abfff 
Generated by running `scripts/bump-cfnspec.sh`. Wanted to speed up the additions required for #17290 .

Feel free to close if this is supposed to be created by a bot like #17223 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@aws-cdk-automation @madeline-k
@iliapolo @TikiTDO
feat(cfnspec): cloudformation spec v46.0.0 (aws#17223)
7bc00f2 
* feat: cloudformation spec v46.0.0

* fix generated code for new libraries: aws-panorama, aws-rekognition, aws-wisdom

* fix ec2

* Revert "fix ec2"

This reverts commit d961dde.

* add awslint excludes to ec2 module

* fix secretsmanager - add default RemovalPolicy

* update snapshot tests in aws-docdb because of secretsmanager removal policy change

* amplify

* elasticsearch and opensearch

* esc snapshots

* rds snapshots

Co-authored-by: AWS CDK Team <aws-cdk@amazon.com>
Co-authored-by: Madeline Kusters <mkusters@amazon.com>
Co-authored-by: Eli Polonsky <epolon@amazon.com>
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@ayush987goyal @TikiTDO
feat(cfnspec): cloudformation spec v47.0.0 (aws#17350)
15822f5 
Generated by running `scripts/bump-cfnspec.sh`. Wanted to speed up the additions required for aws#17290 .

Feel free to close if this is supposed to be created by a bot like aws#17223 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliapolo iliapolo iliapolo approved these changes

@github-actions github-actions[bot] github-actions left review comments

Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/cfnspec pr/auto-approve Notifies the GH action to auto-approve this PR pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aws-cdk-automation @madeline-k @iliapolo @rix0rrr