Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-codepipeline-actions): custom-action-registration and common are not exported in index.ts #17039

Closed
rayjanwilson opened this issue Oct 18, 2021 · 3 comments · Fixed by #17041
Labels
@aws-cdk/aws-codepipeline-actions bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1

Comments

@rayjanwilson
Copy link
Contributor

What is the problem?

When you want to create your own custom action, you need to register it. Using CustomActionRegistration from custom-action-registration.ts makes this easy, and it's already exported from that ts file. However, to use it as part of the @aws-cdk/aws-codepipeline-action module, that class needs to be exported on the index.ts file in that directory. Currently, the contents of custom-action-registration.ts are not exported from the index.ts. This is also true for sourceArtifactBounds and deployArtifactBounds from the common.ts file.

Reproduction Steps

import { CustomActionRegistration } from '@aws-cdk/aws-codepipeline-actions';

Module '"@aws-cdk/aws-codepipeline-actions"' has no exported member 'CustomActionRegistration'.
Module '"@aws-cdk/aws-codepipeline-actions"' has no exported member 'sourceArtifactBounds'.
Module '"@aws-cdk/aws-codepipeline-actions"' has no exported member 'deployArtifactBounds'.

What did you expect to happen?

Expected the content of custom-action-registration.ts and common.ts in the @aws-cdk/aws-codepipeline-actions module to be available in the library module.

What actually happened?

The content of custom-action-registration.ts and common.ts in the @aws-cdk/aws-codepipeline-actions module are not in the library module because they are not exported in the index.ts

CDK CLI Version

1.128.0

Framework Version

No response

Node.js Version

v16.11.1

OS

os x

Language

Typescript

Language Version

No response

Other information

No response

@rayjanwilson rayjanwilson added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2021
@rayjanwilson
Copy link
Contributor Author

i'm able to provide a pr to fix this

@peterwoodworth
Copy link
Contributor

Thanks for submitting this issue and creating a PR for it! Certainly seems to be a mistake, but I'm going to ping @skinny85 just in case

@peterwoodworth peterwoodworth added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2021
@skinny85 skinny85 added the in-progress This issue is being actively worked on. label Oct 18, 2021
@skinny85 skinny85 removed their assignment Oct 18, 2021
@mergify mergify bot closed this as completed in #17041 Nov 4, 2021
mergify bot pushed a commit that referenced this issue Nov 4, 2021
)

fixes #17039

all it does is add `./common` and `./custom-action-registration` to the modules `index.ts`

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
…#17041)

fixes aws#17039

all it does is add `./common` and `./custom-action-registration` to the modules `index.ts`

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codepipeline-actions bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants