(aws-ecs): configFileValue should be optional in FirelensOptions #16594
Labels
@aws-cdk/aws-ecs
Related to Amazon Elastic Container
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
configFileValue is defined as a required value in FirelensOptions
Reproduction Steps
configFileValue should be marked as optional here
aws-cdk/packages/@aws-cdk/aws-ecs/lib/firelens-log-router.ts
Line 64 in 7966f8d
What did you expect to happen?
I expect that a config like this example for Datadog is valid
https://github.com/aws-samples/amazon-ecs-firelens-examples/blob/mainline/examples/fluent-bit/datadog/task-definition.json
What actually happened?
Above config doesn't work since configFileValue is mandatory.
Environment
I'd be happy to provide an MR for this
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: