Skip to content

feat(efs): add support for transitioning files from infrequent access to primary storage #16522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 15, 2021
Merged

feat(efs): add support for transitioning files from infrequent access to primary storage #16522

merged 5 commits into from
Dec 15, 2021
+56 −3

Conversation

longtv2222
Copy link
Contributor

@longtv2222 longtv2222 commented Sep 17, 2021 •
edited by corymhall
Loading

This PR adds support for TransitionToPrimaryStorageClass for AWS::EFS::FileSystem

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 17, 2021

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@longtv2222 longtv2222 force-pushed the efs-add-transition-to-primary-storage branch from a620507 to 4c0a3d6 Compare September 17, 2021 07:40
@longtv2222 longtv2222 changed the title feat(aws-efs) : add support for transitioning files from infrequence access (IA) to primary storage feat(efs): add support for transitioning files from infrequent access to primary storage Sep 17, 2021
@longtv2222 longtv2222 force-pushed the efs-add-transition-to-primary-storage branch from 4c0a3d6 to fb453b6 Compare September 17, 2021 08:04
@longtv2222 longtv2222 force-pushed the efs-add-transition-to-primary-storage branch from 819b9b8 to 9e6cd65 Compare October 1, 2021 04:44
@peterwoodworth peterwoodworth changed the title feat(efs): add support for transitioning files from infrequent access to primary storage feat(efs): add support for transitioning files from infrequent access to primary storage Oct 21, 2021
@github-actions github-actions bot added the @aws-cdk/aws-efs Related to Amazon Elastic File System label Oct 21, 2021
@nija-at nija-at added effort/small Small work item – less than a day of effort p2 labels Oct 28, 2021
@nija-at nija-at removed their assignment Oct 28, 2021
@corymhall
Copy link
Contributor

@longtv2222 are you still able to work on this PR? I can't see why the build is failing anymore so if you can fix the conflicts and trigger a new build I can review.

@corymhall corymhall self-assigned this Dec 14, 2021
@longtv2222
Copy link
Contributor Author

longtv2222 commented Dec 14, 2021 •
edited
Loading

@corymhall Yes, I'm able to work on this PR. Will fix the conflicts later today!

corymhall
corymhall approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Merge branch 'master' into efs-add-transition-to-primary-storage

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8dcdc31
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8dcdc31
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 65414c6 into aws:master Dec 15, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@corymhall corymhall mentioned this pull request Jan 26, 2022
Closed
2 tasks
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@longtv2222 @TikiTDO
feat(efs): add support for transitioning files from infrequent access…
318ab81 
… to primary storage (aws#16522)

This PR adds support for [TransitionToPrimaryStorageClass](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-efs-filesystem-lifecyclepolicy.html) for ``AWS::EFS::FileSystem``

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corymhall corymhall

Assignees

@corymhall corymhall

Labels
@aws-cdk/aws-efs Related to Amazon Elastic File System effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@longtv2222 @corymhall @aws-cdk-automation @nija-at