feat(pipelines): ECR source action

[alexpulver]

Closes #16378

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[alexpulver]

I will need to rework the actionName definition, because / can appear in ECR repository name (namespace), and is not a valid character in CodePipeline action name.

Pull request has been modified.

[alexpulver]

@rix0rrr I changed the code to handle the / namespace character by replacing it with _ character. I tested manually that const formattedRepositoryName = Fn.join('_', Fn.split('/', this.repository.repositoryName)); works on repositories with and without namespace, because I don't think it's possible to test without deploying the stack. Below are the snippets from the template I used for manual testing. Can you please let me know if it's acceptable from your perspective?

No namespace:

{
  "Resources": {
    "Repository22E53BBD": {
      "Type": "AWS::ECR::Repository"
    },
<snip>

With namespace:

{
  "Resources": {
    "Repository22E53BBD": {
      "Type": "AWS::ECR::Repository",
      "Properties": {
        "RepositoryName": "namespace/repo"
      }
    },
<snip>

Pipeline:

{
  "Resources": {
    <snip>
    "Pipeline9850B417": {
      "Type": "AWS::CodePipeline::Pipeline",
      "Properties": {
        "RoleArn": {
          "Fn::GetAtt": [
            "PipelineRoleB27FAA37",
            "Arn"
          ]
        },
        "Stages": [
          {
            "Actions": [
              {
                "InputArtifacts": [],
                "ActionTypeId": {
                  "Version": "1",
                  "Owner": "AWS",
                  "Category": "Source",
                  "Provider": "ECR"
                },
                "OutputArtifacts": [
                  {
                    "Name": "Source"
                  }
                ],
                "RunOrder": 1,
                "Configuration": {
                  "ImageTag": "latest",
                  "RepositoryName": {
                    "Ref": "Repository22E53BBD"
                  }
                },
                "Name": {
                  "Fn::Join": [
                    "_",
                    {
                      "Fn::Split": [
                        "/",
                        {
                          "Ref": "Repository22E53BBD"
                        }
                      ]
                    }
                  ]
                }
              }
            ],
            "Name": "Source"
          },
<snip>

[alexpulver]

@rix0rrr would be glad to have your input on the above

Pull request has been modified.

[npvisual]

@alexpulver : should the following comments have been modified ? I think they still apply to the s3 factory method.

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 1761505
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).