Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(pipelines): Specifying variable namespace for pipelines.CodeBuildStep #15943

Closed
2 tasks
markusl opened this issue Aug 9, 2021 · 2 comments · Fixed by #19024
Closed
2 tasks

(pipelines): Specifying variable namespace for pipelines.CodeBuildStep #15943

markusl opened this issue Aug 9, 2021 · 2 comments · Fixed by #19024
Labels
@aws-cdk/pipelines CDK Pipelines library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@markusl
Copy link
Contributor

markusl commented Aug 9, 2021

We are currently looking into the new pipelines API but I cannot seem to find a way to specify variable namespace for pipelines.CodeBuildStep. Is this implemented or is this a missing feature from the new API?

Use Case

We would like to execute commands and use their outputs in the CodePipeline:

const command = new pipelines.CodeBuildStep('customaction', {
    partialBuildSpec: ...,
    commands: [],
  });
props.stageDeployment.addPost(command);

const variableName = command.variable('OUTPUT_NAME');

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@markusl markusl added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 9, 2021
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Aug 9, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 10, 2021

Not really part of the design target so far, but I see no harm in adding it. The proposed variable function can return "#{NameSpace14851.OUTPUT_NAME}".

@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 10, 2021
@rix0rrr rix0rrr removed their assignment Aug 10, 2021
rix0rrr added a commit that referenced this issue Feb 17, 2022
feat(pipelines): step outputs

Make it possible to export environment variables from a CodeBuildStep,
and pipeline sources, and use them in the environment variables of
a CodeBuildStep or ShellStep.

Closes #17189, closes #18893, closes #15943, closes #16407.
@mergify mergify bot closed this as completed in #19024 Feb 23, 2022
mergify bot pushed a commit that referenced this issue Feb 23, 2022
Make it possible to export environment variables from a CodeBuildStep,
and pipeline sources, and use them in the environment variables of
a CodeBuildStep or ShellStep.

Closes #17189, closes #18893, closes #15943, closes #16407.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
2 participants