Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cloudwatch: Add missing statistics #14688

Closed
RyanDawkins opened this issue May 13, 2021 · 3 comments
Closed

aws-cloudwatch: Add missing statistics #14688

RyanDawkins opened this issue May 13, 2021 · 3 comments
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@RyanDawkins
Copy link

Add missing statistics to Statistic enum for cloud watch graphs.

Use Case

Graphing p50, p90, p99 metrics using the CDK.

Proposed Solution

Update the enum to include p50/p90/p99

https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-cloudwatch.Statistic.html

Other

https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-cloudwatch.Statistic.html

  • 👋 I may be able to implement this feature request

This is a 🚀 Feature Request

@RyanDawkins RyanDawkins added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 13, 2021
@github-actions github-actions bot added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label May 13, 2021
@NetaNir NetaNir added p2 effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md and removed good first issue Related to contributions. See CONTRIBUTING.md labels May 14, 2021
@RyanDawkins
Copy link
Author

RyanDawkins commented May 20, 2021

A hack around this if you're using TypeScript in case you run into this issue:

import { Statistic as MonoCdkStatistic } from 'monocdk/aws-cloudwatch';

export const Statistic = {
  ...MonoCdkStatistic,
  p50: 'p50',
  p90: 'p90',
  p99: 'p99',
};

const statistic = Statistic.p50 as MonoCdkStatistic;

@NetaNir NetaNir removed their assignment May 20, 2021
@madeline-k madeline-k removed the needs-triage This issue or PR still needs to be triaged. label May 25, 2021
@j-schwerer
Copy link

Does it also cover https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_cloudwatch.MetricOptions.html?

There are now 12 statistics on https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/Statistics-definitions.html, including trimmed mean, percentile rank, etc. in addition to percentiles…

@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Mar 29, 2023
@github-actions github-actions bot closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

4 participants