Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ecs-patterns): Add support for public IP assignment on QueueProcessingFargateService construct #12815

Closed
2 tasks
lnalex opened this issue Feb 2, 2021 · 2 comments · Fixed by #13122, aws-iot-builder-tools/iot-reference-architectures#1801, aws-samples/keycloak-on-aws#44, aws-samples/keycloak-on-aws#46 or aws-samples/amazon-emr-with-juicefs#80
Closed
2 tasks

(ecs-patterns): Add support for public IP assignment on QueueProcessingFargateService construct #12815

lnalex opened this issue Feb 2, 2021 · 2 comments · Fixed by #13122, aws-iot-builder-tools/iot-reference-architectures#1801, aws-samples/keycloak-on-aws#44, aws-samples/keycloak-on-aws#46 or aws-samples/amazon-emr-with-juicefs#80
Assignees
@SoManyHs
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library feature-request A feature should be added or improved.

Comments

@lnalex
Copy link
Member

lnalex commented Feb 2, 2021

Allow specifying the assignPublicIp property for QueueProcessingFargateService

Use Case

Allow the use of public IPs and subnets with QueueProcessingFargateService

Proposed Solution

Add a assignPublicIp property to QueueProcessingFargateService, which could be propagated to the underlying FargateService construct here:

aws-cdk/packages/@aws-cdk/aws-ecs-patterns/lib/fargate/queue-processing-fargate-service.ts

Line 109 in 8990e8f

this.service = new FargateService(this, 'QueueProcessingFargateService', {

Other

#12603 has a workaround noted, though not ideal.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@lnalex lnalex added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 2, 2021
@peterwoodworth peterwoodworth added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Feb 2, 2021
@lgvo
Copy link
Contributor

lgvo commented Feb 5, 2021 •
edited

I can change #12604 to cover both #12815 and #12603. I just need to know if the API changes are ok and maybe have someone take a quick look on the PR before I put any more work on it.

@SoManyHs SoManyHs removed the needs-triage This issue or PR still needs to be triaged. label Feb 15, 2021
@lgvo lgvo mentioned this issue Feb 17, 2021
Merged
@mergify mergify bot closed this as completed in #13122 Feb 18, 2021
mergify bot pushed a commit that referenced this issue Feb 18, 2021
@lgvo
feat(ecs-patterns): Add support for assignPublicIp for QueueProcessin…
3fb4600 
…gFargateService (#13122)

Resolve #12815

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

NovakGu pushed a commit to NovakGu/aws-cdk that referenced this issue Feb 18, 2021
@lgvo @NovakGu
feat(ecs-patterns): Add support for assignPublicIp for QueueProcessin…
89643a0 
…gFargateService (aws#13122)

Resolve aws#12815

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this issue Feb 22, 2021
@lgvo
feat(ecs-patterns): Add support for assignPublicIp for QueueProcessin…
6678afe 
…gFargateService (#13122)

Resolve #12815

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Mar 6, 2021
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Merged
Closed
This was referenced Mar 8, 2021
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoManyHs SoManyHs

Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs-patterns): Add support for assignPublicIp for QueueProcessingFargateService
Bump awsCdkVersion from 1.90.1 to 1.92.0 in /master-cdk aws-iot-builder-tools/iot-reference-architectures
Bump @aws-cdk/core from 1.91.0 to 1.92.0 in /source aws-samples/keycloak-on-aws
Bump aws-cdk from 1.91.0 to 1.92.0 in /source aws-samples/keycloak-on-aws
Bump aws-cdk from 1.91.0 to 1.92.0 in /source aws-samples/amazon-emr-with-juicefs
Bump @aws-cdk/aws-ec2 from 1.91.0 to 1.92.0 in /source aws-samples/amazon-emr-with-juicefs
Bump awsCdkVersion from 1.90.1 to 1.92.0 aws-samples/aws-cdk-constructs-for-java
Bump @aws-cdk/aws-s3 from 1.91.0 to 1.92.0 in /source aws-samples/amazon-emr-with-juicefs
Bump aws-cdk from 1.91.0 to 1.92.0 peavers-archive/cdk-api-gateway-example
Bump @aws-cdk/assert from 1.91.0 to 1.92.0 in /source aws-samples/keycloak-on-aws
6 participants
@lgvo @uttarasridhar @MrArnoldPalmer @SoManyHs @peterwoodworth @lnalex