Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Review the name of the method extract_data_from_envelope in JMESPath Functions #4218

Open
1 of 2 tasks
leandrodamascena opened this issue Apr 26, 2024 · 1 comment
Labels
jmespath JMESPath Functions utility tech-debt Technical Debt tasks v3 Features that will be included in Powertools v3.
Milestone

Comments

@leandrodamascena
Copy link
Contributor

Why is this needed?

The extract_data_from_envelope method name seems strange for customers to understand what it is for. We now have the opportunity to deprecate this method, add a warning, and create a new one.

Which area does this relate to?

JMESPath functions

Suggestion

Deprectaed this method.

Acknowledgment

@leandrodamascena leandrodamascena added triage Pending triage from maintainers tech-debt Technical Debt tasks jmespath JMESPath Functions utility labels Apr 26, 2024
@leandrodamascena leandrodamascena added this to the Powertools v3 milestone Apr 26, 2024
@leandrodamascena leandrodamascena added v3 Features that will be included in Powertools v3. and removed triage Pending triage from maintainers labels Apr 26, 2024
@dreamorosi
Copy link
Contributor

We just added this method in the TypeScript repo a few weeks ago.

Do we have any anecdotes for deprecating this and how we can improve?

I'm not necessarily challenging the idea, I'm more interested in how we can disambiguate it and make it clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jmespath JMESPath Functions utility tech-debt Technical Debt tasks v3 Features that will be included in Powertools v3.
Projects
Status: Working on it
Development

No branches or pull requests

2 participants