Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Note on default payload_format_version when using Terraform's apigatewayv2 #4089

Open
1 task done
rubenfonseca opened this issue Apr 8, 2024 · 1 comment
Open
1 task done
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@rubenfonseca
Copy link
Contributor

What were you searching in the docs?

When reading the docs on the API Gateway HTTP integration we find this:

Using HTTP API v1 payload? Use APIGatewayRestResolver instead. APIGatewayHttpResolver defaults to v2 payload.

However, when using Terraform's API Gateway v2 module, it defaults to payload version v1.

This can take a long time to debug.

Is this related to an existing documentation section?

https://docs.powertools.aws.dev/lambda/python/latest/core/event_handler/api_gateway/#api-gateway-http-api

How can we improve?

Add a note to the documentation that you need to explicitly tell Terraform to use the v2 payload format version.

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@rubenfonseca rubenfonseca added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Apr 8, 2024
@rubenfonseca rubenfonseca self-assigned this Apr 8, 2024
@rubenfonseca rubenfonseca removed the triage Pending triage from maintainers label Apr 8, 2024
@leandrodamascena
Copy link
Contributor

I agree that we can improve our documentation to make it clearer. And I've already opened an issue in the Terraform repository to change this and maintain the same behavior when using AWS and Terraform.

hashicorp/terraform-provider-aws#37035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Backlog
Development

No branches or pull requests

2 participants