Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Idempotent Batch Processing example #1763

Closed
1 task done
andrewhharmon opened this issue Dec 7, 2022 · 4 comments · Fixed by #1776
Closed
1 task done

Fix Idempotent Batch Processing example #1763

andrewhharmon opened this issue Dec 7, 2022 · 4 comments · Fixed by #1776
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@andrewhharmon
Copy link

What were you searching in the docs?

Trying to understand why my code was throwing the following warning when trying to process SQS records with an idempotent function UserWarning: Couldn't determine the remaining time left. Did you call register_lambda_context on IdempotencyConfig?

Is this related to an existing documentation section?

https://awslabs.github.io/aws-lambda-powertools-python/2.4.0/utilities/idempotency/#idempotent_function-decorator

How can we improve?

Please see the discussion here.

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@andrewhharmon andrewhharmon added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Dec 7, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 7, 2022

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Dec 13, 2022
@heitorlessa
Copy link
Contributor

Just rebuilt the latest docs to include the new improvements @andrewhharmon - thank you again for helping improve everyone's experience!

I extracted the batch integration into its own sub-section to make it easier to spot. Included the full snippet with comments, and a note about uniqueness as it's key for idempotency.

https://awslabs.github.io/aws-lambda-powertools-python/2.4.0/utilities/idempotency/#batch-integration

image

@github-actions
Copy link
Contributor

This is now released under 2.5.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
2 participants