feat: autosuggest place id support #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaddmt
previously approved these changes
Sep 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #173 +/- ##
==========================================
+ Coverage 42.94% 43.67% +0.72%
==========================================
Files 16 16
Lines 1248 1264 +16
Branches 169 170 +1
==========================================
+ Hits 536 552 +16
Misses 712 712
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thaddmt
previously approved these changes
Oct 17, 2022
|
Also I believe we may need to preface this PR title with |
sreeramsama
changed the title
thaddmt
approved these changes
Oct 17, 2022
|
🎉 This PR is included in version 2.1.0-unstable.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sreeramsama
added a commit
that referenced
this pull request
Oct 19, 2022
* feat: add Geocoder APIs with test data - getSuggestions, searchByPlaceId * chore: update getSuggestions and searchByPlaceId APIs with unit tests and proper return types * fix: fix unit test and check for undefined return value * chore: use newer version of maplibre-gl-geocoder * chore: use latest @aws-amplify/geo * chore: use latest @aws-amplify/geo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add getSuggestions and searchByPlaceId APIs with unit tests
Issue #, if available
Description of how you validated changes
Manual testing with test data on UI component and unit tests.
Checklist
yarn testpasses