Amplify JS release #10781
Merged
Amplify JS release #10781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com> Co-authored-by: Chris Bonifacio <christopher.bonifacio@gmail.com> Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com> Co-authored-by: Dustin Noyes <dustin.noyes.dev@gmail.com>
…Name when remembering devices (React Native) (#10724) * chore: leveling with upstream * fix(amazon-cognito-identity-js): specify the right userAgent/deviceName when running on react native * chore: remove ui packages to match with upstream main * fix(amazon-cognito-identity-js): modified the userAgent logic to use Platform module * fix: remove use of default Platform import and use a named one * fix: adds a navigator undefined check * chore: add device tracking RN integ test to circleci * fix: add the device tracking test step to workflows and releases Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com> Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com> Co-authored-by: AllanZhengYP <zheallan@amazon.com>
AllanZhengYP
requested review from
Samaritan1011001,
elorzafe and
haverchuck
Samaritan1011001
previously approved these changes
Dec 15, 2022
haverchuck
previously approved these changes
Dec 15, 2022
elorzafe
previously approved these changes
Dec 15, 2022
AllanZhengYP
dismissed stale reviews from elorzafe, haverchuck, and Samaritan1011001
via
c456029
AllanZhengYP
temporarily deployed
to
github-pages
AllanZhengYP
requested review from
haverchuck,
Samaritan1011001 and
elorzafe
elorzafe
approved these changes
Dec 16, 2022
haverchuck
approved these changes
Dec 16, 2022
Samaritan1011001
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.