Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amplify JS release #10768

Merged
merged 6 commits into from Dec 14, 2022
Merged

Amplify JS release #10768

merged 6 commits into from Dec 14, 2022

Conversation

haverchuck
Copy link
Contributor

Description of changes

Amplify JS release from main.

Issue #, if available

N/A

Description of how you validated changes

Manual testing and circle ci -> unstable.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

helgabalashova and others added 4 commits December 7, 2022 11:11
…rt of callback for updateAttributes, adds hub event to Auth.updateUserAttributes (#10731)

* feat(auth): adds hub events to updateUserAttributes api, returns codeDeliveryDetails list as third parameter of updateAttributes callback
* fix(pubsub): AppSync in China regions 
* fix: Add cn test for appsync support change

Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>
@haverchuck haverchuck requested review from a team as code owners December 12, 2022 22:02
@haverchuck haverchuck temporarily deployed to github-pages December 13, 2022 00:15 — with GitHub Pages Inactive
* added nextjs integ tests; expecting failure in '-basic' (#10759)

* added nextjs integ tests; expecting failure in '-basic'

* add ds-nextjs-workaround branch to releasable branches to trigger iteggs

* fixed nextjs circleci framework propr

* fixed sample names in ds nextjs tests

* fix SWC build issue, remove TS v of next/SWC test for later debug

* remove nextjs TS variant integ for real this time

* switched integs back to main

* fully removed next13 TS app from config; renamed other next13 integs for clarity
@svidgen svidgen requested a review from a team as a code owner December 13, 2022 15:41
@svidgen svidgen temporarily deployed to github-pages December 13, 2022 15:43 — with GitHub Pages Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #10768 (24978b4) into release (b339298) will increase coverage by 2.53%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           release   #10768      +/-   ##
===========================================
+ Coverage    83.62%   86.16%   +2.53%     
===========================================
  Files          253      197      -56     
  Lines        18261    18369     +108     
  Branches      3918     3906      -12     
===========================================
+ Hits         15271    15827     +556     
+ Misses        2898     2468     -430     
+ Partials        92       74      -18     
Impacted Files Coverage Δ
...astore/src/storage/adapter/AsyncStorageDatabase.ts 83.92% <0.00%> (-10.52%) ⬇️
packages/datastore/src/storage/storage.ts 90.24% <0.00%> (-7.41%) ⬇️
packages/analytics/src/Analytics.ts 55.89% <0.00%> (-7.03%) ⬇️
packages/pubsub/__tests__/helpers.ts 89.23% <0.00%> (-4.80%) ⬇️
packages/datastore/__tests__/helpers.ts 84.24% <0.00%> (-4.65%) ⬇️
.../datastore/src/storage/adapter/IndexedDBAdapter.ts 85.26% <0.00%> (-2.89%) ⬇️
packages/core/src/JS.ts 90.26% <0.00%> (-1.87%) ⬇️
packages/datastore/__tests__/commonAdapterTests.ts 98.16% <0.00%> (-1.84%) ⬇️
packages/datastore/src/predicates/sort.ts 89.18% <0.00%> (-1.72%) ⬇️
packages/amazon-cognito-identity-js/src/Client.js 50.48% <0.00%> (-1.52%) ⬇️
... and 221 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@manueliglesias manueliglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haverchuck haverchuck merged commit f0c16a5 into release Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants