Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce CodeQL scan #10725

Merged
merged 10 commits into from Nov 30, 2022
Merged

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Nov 29, 2022

Description of changes

The LGTM will stop running for new commits and PRs on 11/30/2022(blog post). This change is part of the effort to migrate the LGTM check to CodeQL workflow.

After introducing this workflow, the vulneribility alerts can be checked on the Security tab of the repo. Here is the example in the forked repo. The docs folder is excluded from the scanning scope as itself takes over 2 hrs to scan. We can setup a separate cron job to run scanning on the docs folder. This behavior corresponds to the current LGTM config.

By default, the PR check would fail if high or critical alert is detected. We can tune down the sensitivity to critical later if we find most of PRs are blocked with the code scanning config.

Issue #, if available

Description of how you validated changes

Validated the behavior in forked repo here.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AllanZhengYP AllanZhengYP requested a review from a team as a code owner November 29, 2022 22:37
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #10725 (a7b7dc6) into main (b1562e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #10725   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files         196      196           
  Lines       18335    18335           
  Branches     3900     3900           
=======================================
  Hits        15715    15715           
  Misses       2544     2544           
  Partials       76       76           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

elorzafe
elorzafe previously approved these changes Nov 30, 2022
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I would remove the comments unless you feel strongly about having those there

.github/workflows/codeql.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants