New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated misconfigured dispatch #10511
Updated misconfigured dispatch #10511
Conversation
Codecov Report
@@ Coverage Diff @@
## main #10511 +/- ##
=======================================
Coverage 86.16% 86.16%
=======================================
Files 197 197
Lines 18369 18371 +2
Branches 3906 3907 +1
=======================================
+ Hits 15827 15829 +2
Misses 2468 2468
Partials 74 74
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me. But I'm not sure whether stop emitting signIn
is a breaking change for those expecting this event. I'd defer to other approvers.
The only concern is that this could be a breaking change in case some one is listening for the |
Ok, that sounds good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @MatthewChon 🎖️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatthewChon Please see inline comment.
Description of changes
Change verifytotptoken() to emit an 'verify' event instead of 'signIn'.
Added the case 'verify' to the listener.
Issue #, if available
#9750
Description of how you validated changes
i reproduced the issue and from there, I reran the application with the modified changes.
The hub now console logs 'verify' instead of 'signIn'.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.