Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analytics] Options builder build should be public #2803

Closed
1 task done
mattcreaser opened this issue May 3, 2024 · 2 comments
Closed
1 task done

[Analytics] Options builder build should be public #2803

mattcreaser opened this issue May 3, 2024 · 2 comments
Assignees
Labels
analytics Related to the Analytics category/plugins bug Something isn't working

Comments

@mattcreaser
Copy link
Contributor

Before opening, please confirm:

Language and Async Model

Java, RxJava

Amplify Categories

Analytics

Gradle script dependencies

// Put output below this line

Environment information

# Put output below this line


Please include any relevant guides or documentation you're referencing

No response

Describe the bug

The AWSPinpointAnalyticsPlugin.Options class was added in the 2.16.0 release. The builder for this class works in Kotlin:

val options = AWSPinpointAnalyticsPlugin.Options {
  // ...
}

but not in Java because the build() function is internal:

AWSPinpointAnalyticsPlugin.Options options = AWSPinpointAnalyticsPlugin.Options.builder()
  // ...
 .build() <-- cannot call

Reproduction steps (if applicable)

No response

Code Snippet

// Put your code below this line.

Log output

// Put your logs below this line


amplifyconfiguration.json

No response

GraphQL Schema

// Put your schema below this line

Additional information and screenshots

No response

@mattcreaser mattcreaser added the analytics Related to the Analytics category/plugins label May 3, 2024
@github-actions github-actions bot added the pending-triage Issue is pending triage label May 3, 2024
@mattcreaser mattcreaser added bug Something isn't working and removed pending-triage Issue is pending triage labels May 3, 2024
@mattcreaser mattcreaser self-assigned this May 6, 2024
@mattcreaser mattcreaser added the pending-release Code has been merged but pending release label May 7, 2024
@mattcreaser
Copy link
Contributor Author

This has been released in Amplify 2.17.0

@github-actions github-actions bot removed the pending-release Code has been merged but pending release label May 17, 2024
Copy link
Contributor

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analytics Related to the Analytics category/plugins bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant