fix: Make tagging optional #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test to cover error thrown if access key exists and no secret key provided
|
@allisaurus can you merge this PR? |
|
@KeifferCulbreth thanks for contributing! Can you please add a blurb in the session tagging section of the README that explains that it can be disabled by setting this new property? Otherwise this looks good to me 🚀 |
Add details about skipping session tagging during role assumption
|
@allisaurus All done! |
allisaurus
approved these changes
Jul 8, 2020
billputer
referenced
this pull request
in billputer/configure-aws-credentials
Jul 9, 2020
* master: chore: Update dist fix: Make tagging optional (#92) chore: Bump eslint from 7.3.1 to 7.4.0 (#94) chore: Update dist chore: Bump aws-sdk from 2.707.0 to 2.708.0 (#90) chore: update dependabot schedule (#89) chore(release): 1.4.2 chore: Update dist chore: Bump aws-sdk from 2.706.0 to 2.707.0 (#88) chore: Switch to GitHub-native Dependabot chore: Update dist chore: Bump aws-sdk from 2.704.0 to 2.706.0 chore: Update dist fix: add comma to set of special characters (#78) chore: Bump jest from 26.0.1 to 26.1.0 chore: Update dist chore: Bump aws-sdk from 2.692.0 to 2.704.0 chore: Bump eslint from 7.2.0 to 7.3.1
billputer
referenced
this pull request
in billputer/configure-aws-credentials
Jul 9, 2020
mergify bot
added a commit
that referenced
this pull request
Aug 4, 2020
* fix: make GITHUB_REF env var optional * Fix conflicts from #92 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81
Description of changes: fix to make tagging optional and improved code coverage
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.