Readme: clarify that aws-session-token supported #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing @holyjak ! Would you mind changing the commit msg* to be semantic (something like "chore: Add aws-session-token notation to README" so that we can merge this in? *to clarify, I mean the actual git history/commit msg in your branch, not just the PR title (common point of confusion) |
|
@holyjak wanted ping you again in case you were still able + interested in resolving the semantic PR check to get this merged |
I nearly gave up, believing it is not supported, until I read the action.yml. I think it is worth making this clear already in the README.
|
Fixed. Thank you for the ping, I have not seen your original comment. |
allisaurus
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README.
I nearly gave up, believing it is not supported, until I read the action.yml. I think it is worth making this clear already in the README.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.