Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inputs executionRoleArn and taskRoleArn #183

Open
hblab-ngocnd opened this issue Sep 1, 2022 · 3 comments
Open

add inputs executionRoleArn and taskRoleArn #183

hblab-ngocnd opened this issue Sep 1, 2022 · 3 comments

Comments

@hblab-ngocnd
Copy link

for security reason, want add input executionRoleArn and taskRoleArn for task definition

@bert2002
Copy link

bert2002 commented Sep 4, 2022

You can simply do this by adding it to the task-definition . E.g.

  "TaskDefinition": {
    "executionRoleArn": "arn:aws:iam::<id>:role/<name>",
    "containerDefinitions": [
      {
...

@hblab-ngocnd
Copy link
Author

hblab-ngocnd commented Sep 5, 2022

@bert2002
But that not good for security because that show Arn Role for viewer.
It is better If input has options for set role from secret key by input

inputs:
task-definition:
description: 'The path to the ECS task definition JSON file'
required: true
container-name:
description: 'The name of the container defined in the containerDefinitions section of the ECS task definition'
required: true
image:
description: 'The URI of the container image to insert into the ECS task definition'
required: true
environment-variables:
description: 'Variables to add to the container. Each variable is of the form KEY=value, you can specify multiple variables with multi-line YAML strings.'
required: false

@dangeReis
Copy link

I agree, hardcoding the parameters in the task-definition is not useful. Can we prioritize this feature request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants