Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to fetch the Task Definition Using AWS API for Node and Then Rendering it. #102

Open
mangeshg opened this issue May 18, 2021 · 6 comments
Assignees
Labels
feature-request A feature should be added or improved. Investigating

Comments

@mangeshg
Copy link

Currently this workflow expects to have the Task Definition Json to be part of the GitHub Repo.

If this action can be enhanced to fetch the task definition just by using family:revision provided to AWS.ECS. describeTaskDefinition API and then rendering it further , Then Users do not need to check in the task definition Json in the Repo.
Optionally - Updated task definition can be registered back using registerTaskDefinition API call with updated ECR Image ID.

This will achieve -

  1. Better user confidence to avoid checking in Spec file containing references to various AWS ARNs (Account Id ) etc.
  2. It will be guaranteed that Task Definition will always be correct / no need to validate its format specs etc.
@paragbhingre
Copy link
Contributor

@mangeshg Thank you for reporting this feature request to us, we will look into this and get back with the appropriate answer to it.

@mangeshg
Copy link
Author

@paragbhingre Thanks Parag , Looking forward to it.

@allisaurus allisaurus added the feature-request A feature should be added or improved. label May 25, 2021
@allisaurus allisaurus removed their assignment Aug 30, 2021
@pktippa
Copy link

pktippa commented Mar 25, 2022

I am also waiting for this feature to be available, I am also willing to contribute if someone can guide me through.

@sblack4
Copy link

sblack4 commented Jul 20, 2022

This would be nice. My workaround is to run this step before the render task def step:

    - name: Get current task definition
      run: >
        aws ecs describe-task-definition
        --task-definition "$TASK_FAMILY" --region "$AWS_DEFAULT_REGION" --query 'taskDefinition'
        > task-definition.json

@protonforest
Copy link

Looking forward to this feature!

@scott-doyland-burrows
Copy link

describe-task-definition

Good workaround, but the issue with this is that the tags are not pulled into the task definition. And removing the --query 'taskDefinition' and including --include TAGS then means it just fails, as the task def is not in the correct format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. Investigating
Projects
None yet
Development

No branches or pull requests

7 participants