Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] MinGW compatibility #43

Open
hgtok opened this issue Oct 2, 2019 · 3 comments
Open

[BUG] MinGW compatibility #43

hgtok opened this issue Oct 2, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@hgtok
Copy link

hgtok commented Oct 2, 2019

Describe the bug
Unable to render UI when running in a MinGW environment

To Reproduce

Expected behavior
Console UI is shown

Screenshots
Attached in reproduce

Environment (please complete the following information):

  • OS: Windows 10, 7 (64bit)
  • PortableGit 2.23.0

Additional context
NA

@hgtok hgtok added the bug Something isn't working label Oct 2, 2019
@mjarkk
Copy link
Member

mjarkk commented Oct 3, 2019

I don't think we can make this possible in the current state of gocui due to the underlying library Termbox-Go,

But... we are thinking about moving to another underlying library to be more further prove because Termbox-Go in not maintained and we have a lot of other small issues that are not solvable due to the use of Termbox-Go.
I can't say if this will happen and if so when because it's just brought up and the changes it requires in gocui will certainly change a lot of the internal code and thus gocui might not be gocui anymore after moving to another underlying library.

Edit:
Just read somethings but cygwin what i assume MinGW is based on but it seems like it's hard for TUI libraries to add support for this. tcell the library we might use has a note in the readme that they don't support this at the moment so even if we would move to another library this still isn't possible but they seems to have some issues and PRs related to supporting cygwin so it might be possible in the further.

@hgtok
Copy link
Author

hgtok commented Oct 4, 2019

Found a workaround for git-bug: winpty git bug termui

But not sure what is the correct syntax for it to work in jsonui due to stdin piping
Tried cat test.json | winpty -Xallow-non-tty ./jsonui_windows_amd64.exe which resulted in

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
Assertion failed!

Program: C:\Program Files\Git\usr\bin\winpty.exe
File: src/libwinpty/winpty.cc, Line 924

Expression: ASSERT_CONDITION("wp != nullptr && cols > 0 && rows > 0")

@mjarkk
Copy link
Member

mjarkk commented Oct 4, 2019

Ya that's a winpty bug
Due to the age of the issue this seems like something that won't be fixed very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants