Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tabs #10

Open
glvr182 opened this issue Apr 27, 2019 · 5 comments
Open

Adding tabs #10

glvr182 opened this issue Apr 27, 2019 · 5 comments
Labels
enhancement New feature or request needs comment This issue needs comments

Comments

@glvr182
Copy link
Member

glvr182 commented Apr 27, 2019

Describe the feature you'd like
Sometime there is just not enough room in the terminal, or two views are
closely related. This calls for a new thing called a "tab". Just like with your browser, a tab holds different information but does not require you to start up a new window.

Describe alternatives you've considered
Manual tabbing, but it is a pain for the developer to create this each and every time.

Additional context
The title of the view would look like this: ─Tab one / Tab two─. and the current tab would be highlighted.

@glvr182 glvr182 added enhancement New feature or request needs comment This issue needs comments labels Apr 27, 2019
@mjarkk
Copy link
Member

mjarkk commented Apr 27, 2019

The idea of tabs is amazing thought ─Tab one / Tab two─ looks a bit off to me.
I'm also wondering how this would look on small screens when having more than 2 tabs: ─Tab one/T/T/T─.

@glvr182
Copy link
Member Author

glvr182 commented Apr 27, 2019

Agreed, I still have to find a good way of displaying tabs. This was my first thought. I think when terminals are too small to display a title we should cut it per tab. So lets say it is first First / Second it would go to
F / S

@vladkras
Copy link

vladkras commented Jul 16, 2019

Or maybe
┌─| First | Second |──

┌─ First | Second ──

@mjarkk
Copy link
Member

mjarkk commented Jul 26, 2019

@vladkras I think it's a bad idea to use | because it's the same character as the box frame.
I think this could be confusing when the terminal gets too small or overlap because the | might look like a border.

@glvr182
Copy link
Member Author

glvr182 commented Oct 13, 2019

Picking this up again after #41
Will integrate the following commits:
jesseduffield@619845f
jesseduffield@3219759
jesseduffield@117e4fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs comment This issue needs comments
Projects
None yet
Development

No branches or pull requests

3 participants