atMost not respected if blocking method used in until

[bencvdb]

You can run this code to replicate the issue:

import org.awaitility.Awaitility;
import java.time.Duration;
import java.util.Scanner;

public class Test {

    public static void main(String[] args) {
        new Test().test();
    }

    public void test() {
        Scanner in = new Scanner(System.in);
        Awaitility.await().pollDelay(Duration.ZERO).atMost(Duration.ofNanos(1)).until(in::hasNextLine);

        if (in.hasNextLine()) {
            String query = in.nextLine();
            System.out.print("recieved: " + query);
        }
    }
}

Expected behavior: ConditionTimeoutException thrown "immediately"
Actual behavior: Code hangs until a value is entered via stdin.

Suspected issue:
It looks like there is a bug in org.awaitility.core.Uninterruptibles#shutdownUninterruptibly:

awaitility/awaitility/src/main/java/org/awaitility/core/Uninterruptibles.java

Lines 122 to 146 in c4962d8

	static void shutdownUninterruptibly(ExecutorService executor, long timeout, TimeUnit unit) {
	boolean interrupted = false;
	try {
	long remainingNanos = unit.toNanos(timeout);
	long end = System.nanoTime() + remainingNanos;
	executor.shutdown();
	while (true) {
	try {
	if (!executor.awaitTermination(remainingNanos, unit)) {
	executor.shutdownNow();
	}
	break;
	} catch (InterruptedException e) {
	interrupted = true;
	remainingNanos = end - System.nanoTime();
	executor.shutdownNow();
	}
	}
	} finally {
	if (interrupted) {
	Thread.currentThread().interrupt();
	}
	}
	}

The method attempts to shutdown the executor running the until condition. In this case, it is being called here:

awaitility/awaitility/src/main/java/org/awaitility/core/ExecutorLifecycle.java

Line 74 in c4962d8

return new EvaluationCleanup(executor -> shutdownUninterruptibly(executor, 1, TimeUnit.SECONDS), ExecutorService::shutdownNow);

Consequently it waits for 10^9 seconds instead of 1 second.

The fix is to edit the condition in line:

awaitility/awaitility/src/main/java/org/awaitility/core/Uninterruptibles.java

Line 131 in c4962d8

if (!executor.awaitTermination(remainingNanos, unit)) {

to be:

!executor.awaitTermination(remainingNanos, NANOSECONDS)

[TheNitek]

I created a PR: #234