Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Default Web Upload File Size Limit #5790

Open
2 tasks
joncameron opened this issue Apr 19, 2024 · 2 comments
Open
2 tasks

Change Default Web Upload File Size Limit #5790

joncameron opened this issue Apr 19, 2024 · 2 comments

Comments

@joncameron
Copy link
Contributor

joncameron commented Apr 19, 2024

Description

Avalon's file size limit for web upload is currently set to a default of 2 GB. This seems unnecessarily low and and an artificial restriction at this point, and this value can be removed unless specified in the system config.

Done Looks Like

  • Limit is disabled if max_upload_size is not present in config (:none)
  • Avalon respects :none value for web upload files (no rejection of files based on size in server file handling)
@cjcolvar
Copy link
Member

cjcolvar commented Apr 19, 2024

It is currently possible for implementors to increase this via a setting but we could increase the default to something larger than 2GB. Given our interest in removing the limit entirely in some cases, I wonder if we should add a configuration setting value like -1 to disable the limit.

https://github.com/avalonmediasystem/avalon/blob/main/app/models/master_file.rb#L184

Possible code changes:

  • Bump size limit (MasterFile::MAXIMUM_UPLOAD_SIZE)
    • What should the new limit be?
  • Disable limit entirely if set to -1 or :none

@joncameron
Copy link
Contributor Author

Need to make sure the handling is working properly; multiple files uploaded at the same time through web upload might have an appended filename and could cause issues, but maybe not. Removing the limit completely would be a reasonable default at this point as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants