Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] NoMethodError: undefined method `full_messages' for []:Array in SupplementalFilesController#create #5784

Open
3 tasks
cjcolvar opened this issue Apr 12, 2024 · 0 comments
Labels

Comments

@cjcolvar
Copy link
Member

cjcolvar commented Apr 12, 2024

It appears that if the creation of a SupplementalFile fails (or under certain failure conditions) then this error gets raised. It could be that our code is just wrong and we should be calling full_messages on something else or not at all. I think we can determine this by writing some tests that exercise this bit of the code.

raise Avalon::SaveError, @object.errors[:supplemental_files_json].full_messages unless @object.save

https://app.honeybadger.io/projects/54117/faults/82392074

Done Looks Like

  • Figure out the right method to call in this case
  • Change the call to make sure errors when saving, or raising errors returns something to users besides a standard system error message
  • Add test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant