Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require TypeScript 4.7 #3041

Merged
merged 9 commits into from Jul 10, 2022
Merged

Require TypeScript 4.7 #3041

merged 9 commits into from Jul 10, 2022

Conversation

novemberborn
Copy link
Member

@novemberborn novemberborn commented Jun 2, 2022 •
edited

  • Only test against TypeScript 4.7
  • Move type definitions to entrypoints/. Only TS 4.7 will resolve them now, but it's cleaner.
  • Remove direct invocation of tsd, rely on tsc --noEmit instead
  • Test with .cts files, containing ESM import syntax

@novemberborn novemberborn mentioned this pull request Jun 2, 2022
Open
@novemberborn novemberborn added the breaking requires a SemVer major release label Jun 2, 2022
@novemberborn novemberborn force-pushed the require-ts4.7 branch 2 times, most recently from 68266d9 to 7986182 Compare June 5, 2022 17:38
@novemberborn
Copy link
Member Author

I'd like to test CJS import syntax as well but I already cannot remember how that's meant to be configured and used.

@novemberborn
Use tsc directly, avoid npx, print actual version
0f0afe9 
Somehow `npx tsc` was pointing at an older version. Possibly the binstubs are corrupted in CI… somehow.
@novemberborn novemberborn marked this pull request as ready for review July 10, 2022 16:28
@novemberborn novemberborn merged commit 02f4e27 into main Jul 10, 2022
@novemberborn novemberborn deleted the require-ts4.7 branch July 10, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking requires a SemVer major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@novemberborn