Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing slashes break directory matching #2781

Closed
jonahsnider opened this issue Jun 27, 2021 · 1 comment · Fixed by #2788
Closed

Trailing slashes break directory matching #2781

jonahsnider opened this issue Jun 27, 2021 · 1 comment · Fixed by #2788
Labels
breaking requires a SemVer major release bug current functionality does not work as desired help wanted
Milestone
4.0

Comments

@jonahsnider
Copy link

Works:

{
  "ava": {
    "files": ["!src/test"]
  }
}

Doesn't work:

{
  "ava": {
    "files": ["!src/test/"]
  }
}

See prettier/prettier#11000 for similar issue
@novemberborn novemberborn added breaking requires a SemVer major release bug current functionality does not work as desired help wanted and removed needs triage labels Jun 30, 2021
@novemberborn
Copy link
Member

I agree that should work.

@novemberborn novemberborn added this to the 4.0 milestone Jun 30, 2021
@asaid-0 asaid-0 mentioned this issue Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking requires a SemVer major release bug current functionality does not work as desired help wanted
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Normalize glob patterns with trailing slashes asaid-0/ava
2 participants
@novemberborn @jonahsnider