Include inner exception message in outer exception message when wrapping exceptions from constructors

[alexmg]

From rikard.p...@gmail.com on September 06, 2011 17:39:15

I have a problem propagating exceptions from my library.
For example:

public class ThrowException
{
public ThrowException()
{
throw new FileNotFoundException("Can't find file");
}
}

[TestMethod]
public void CorrectExceptionWhenResolving()
{
var builder = new ContainerBuilder();
builder.RegisterType();
var container = builder.Build();

try
{
    container.Resolve<ThrowException>();
    Assert.Fail("Exception expected");
}
catch(FileNotFoundException)
{
}
catch(DependencyResolutionException dre)
{
    Assert.IsTrue(dre.Message.Contains("Can't find file"));
}
catch
{
    Assert.Fail("Unexpected exception");
}

}

Ideally I would like to catch FileNotFoundException, but I understand why that is not possible.
What I think would be great is that DependencyResolutionException message contains inner exception message. That way I don't need to explain to users that they should look at the inner exception instead of main exception.

For example this message "An exception was thrown while invoking the constructor 'Void .ctor()' on type 'ThrowException'. Exception: Can't find file" would be much better.

Regards,
Rikard

Original issue: http://code.google.com/p/autofac/issues/detail?id=343

[alexmg]

From nicholas...@gmail.com on January 22, 2012 21:14:05

Thanks Rikard, sounds like a good suggestion.

Status: Accepted
Labels: -Type-Defect Type-Enhancement

[alexmg]

From nicholas...@gmail.com on January 22, 2012 21:16:33

Summary: Include inner exception message in outer exception message when wrapping exceptions from constructors

[alexmg]

From travis.illig on September 21, 2012 09:33:31

Labels: Module-Core

[alexmg]

From j...@q42.nl on September 25, 2012 02:05:00

In the mean time, is it possible to log the exception?

[alexmg]

From travis.illig on January 02, 2013 12:26:27

Owner: travis.illig

[alexmg]

From travis.illig on January 02, 2013 12:45:13

The message for DependencyResolutionException now includes the inner exception message if there is one. It will appear like:

"Unable to resolve component. ---> Can't find file. (See inner exception for details.)"

If the complete stack trace and everything for the inner exception is desired, use ToString as with other exception types.

There is currently no logging built into Autofac. If you want the exception logged, I'd recommend implementing a logging solution in your project. Adding logging to Autofac is outside the scope of this issue.

Status: Fixed