Capture prop injection instance when the middleware runs #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than using the final instance from the request context.
Codecov Report
@@ Coverage Diff @@
## develop #1205 +/- ##
===========================================
- Coverage 75.81% 75.77% -0.05%
===========================================
Files 189 189
Lines 4677 4677
Branches 956 956
===========================================
- Hits 3546 3544 -2
- Misses 675 676 +1
- Partials 456 457 +1
Continue to review full report at Codecov.
|
tillig
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1204; we capture the activated instance in the middleware now, and while we do populate it later, we're populating the right instance.