Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OperationSucceeded flag to OperationTraceCompletedArgs. #1202

Merged
merged 1 commit into from Sep 27, 2020

Conversation

alistairjevans
Copy link
Member

Just add the flag to the event object.

Fixes #1201.

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #1202 into develop will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1202      +/-   ##
===========================================
+ Coverage    75.76%   75.81%   +0.05%     
===========================================
  Files          189      189              
  Lines         4675     4677       +2     
  Branches       956      956              
===========================================
+ Hits          3542     3546       +4     
+ Misses         676      675       -1     
+ Partials       457      456       -1     
Impacted Files Coverage Δ
src/Autofac/Diagnostics/DefaultDiagnosticTracer.cs 82.60% <100.00%> (ø)
...Autofac/Diagnostics/OperationTraceCompletedArgs.cs 87.50% <100.00%> (+4.16%) ⬆️
src/Autofac/Util/AsyncReleaseAction.cs 85.71% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3be18...3821f58. Read the comment docs.

@tillig
Copy link
Member

tillig commented Sep 27, 2020

We'll need a corresponding update in the DotGraph package.

Copy link
Member

@tillig tillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💫

@tillig tillig merged commit 0aa6e7a into autofac:develop Sep 27, 2020
@alistairjevans
Copy link
Member Author

I'll raise an issue in the DotGraph repo, we can fix it when we update it to the released v6 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostics: Add 'Succeeded' flag to OperationTraceCompletedArgs
3 participants