Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics: Add 'Succeeded' flag to OperationTraceCompletedArgs #1201

Closed
alistairjevans opened this issue Sep 27, 2020 · 1 comment · Fixed by #1202
Closed

Diagnostics: Add 'Succeeded' flag to OperationTraceCompletedArgs #1201

alistairjevans opened this issue Sep 27, 2020 · 1 comment · Fixed by #1202

Comments

@alistairjevans
Copy link
Member

While putting together a blog post on the v6 release, it occurred to me that we do not have a way for Diagnostic Event handlers to know whether the Trace they are getting is for a successful resolve operation, or a failing one.

I can imagine users might want to save failing resolves to whatever output, to reduce the amount of trace they have to wade through when diagnosing errors in a bigger system.

I think we should add a boolean OperationSucceeded flag to OperationTraceCompletedArgs, which just indicates whether the operation failed or not. We already have this information available in the Diagnostic Tracer, so should be a trivial addition.

I'll raise a PR for the change, but thought I'd raise the issue first for discussion.

@tillig
Copy link
Member

tillig commented Sep 27, 2020

Good point. The way the tracers know is by intercepting the diagnostic event but that doesn't surface in the rendered trace content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants