Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crdb: touch overlap key on namespace write #357

Merged
merged 4 commits into from Jan 5, 2022
Merged

crdb: touch overlap key on namespace write #357

merged 4 commits into from Jan 5, 2022

Conversation

ecordell
Copy link
Contributor

@ecordell ecordell commented Dec 28, 2021 •
edited

this will ensure that namespace write transactions conflict with tuple
write transactions, and prevent the newenemy problem for interactions
such as:

  • write a tuple
  • write namespace (always fully consistent)
  • do a check with the revision from the tuple write

@github-actions github-actions bot added the area/datastore Affects the storage system label Dec 28, 2021
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Dec 30, 2021
@ecordell ecordell force-pushed the overlap-ns branch 22 times, most recently from 76e036f to 4f69871 Compare January 3, 2022 16:39
@github-actions github-actions bot removed the area/datastore Affects the storage system label Jan 3, 2022
@ecordell ecordell force-pushed the overlap-ns branch 3 times, most recently from 53f1f24 to a5a4eb4 Compare January 3, 2022 20:54
@github-actions github-actions bot added the area/datastore Affects the storage system label Jan 3, 2022
@ecordell ecordell force-pushed the overlap-ns branch 15 times, most recently from eece189 to 2f60d97 Compare January 4, 2022 20:43
@ecordell ecordell marked this pull request as ready for review January 4, 2022 20:49
@ecordell ecordell marked this pull request as draft January 4, 2022 21:01
@ecordell ecordell force-pushed the overlap-ns branch 3 times, most recently from 9fc4abb to 4c740b4 Compare January 4, 2022 22:09
@ecordell
e2e: test namespace consistency
5a25fd0
@ecordell
simplify build for e2e
6c294c7
@ecordell
crdb: touch overlap key on namespace write
41f1a6b 
this will ensure that namespace write transactions conflict with tuple
write transactions, and prevent the newenemy problem for interactions
such as:

- write namespace (always fully consistent)
- write a tuple
- do a check with the revision from the tuple write
@ecordell ecordell marked this pull request as ready for review January 4, 2022 22:17
@ecordell ecordell requested a review from jakedt January 5, 2022 22:31
@jakedt jakedt merged commit fac38b3 into authzed:main Jan 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakedt jakedt jakedt approved these changes

Assignees
No one assigned
Labels
area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ecordell @jakedt