Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/testutil: ensure types in RequireEqualEmptyNil #355

Merged
merged 1 commit into from Dec 28, 2021
Merged

Conversation

jzelinskie
Copy link
Member

Previously we were not checking that the values were the same type, only types that had lengths.
This now ensures expected and actual are the same types.

@jzelinskie jzelinskie added kind/bug Something is broken or regressed area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Dec 28, 2021
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzelinskie jzelinskie merged commit 9a8f598 into main Dec 28, 2021
@jzelinskie jzelinskie deleted the testutil-fix branch December 28, 2021 22:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) kind/bug Something is broken or regressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants