Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter for many packages #352

Merged
merged 27 commits into from Dec 28, 2021
Merged

Fix linter for many packages #352

merged 27 commits into from Dec 28, 2021

Conversation

jzelinskie
Copy link
Member

@jzelinskie jzelinskie commented Dec 25, 2021 •
edited

  • The only packages that are ignored by revive stutter in a way that I'm not really comfortable changing yet, because I feel like it'd cascade into renaming almost all the types/functions in those packages.
  • I tried to use every linter in golanglint-ci that was reasonably easy adopt
  • I vendored gofumpt/stringer similar to how we vendor optgen in tools.go
  • I implemented a pkg/testutil that includes an equality function that treats []T(nil) and []T{} as equal
  • The names of some of the metrics did not follow Prometheus idioms and so they were renamed (promlint will enforce this in the future)

@jzelinskie jzelinskie added priority/3 low This would be nice to have area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) kind/tech debt Addresses legacy code/decisions labels Dec 25, 2021
@github-actions github-actions bot added area/api v0 Affects the v0 API area/api v1 Affects the v1 API area/dispatch Affects dispatching of requests area/schema Affects the Schema Language area/dependencies Affects dependencies area/datastore Affects the storage system area/CLI Affects the command line area/dashboard Affects the dashboard labels Dec 25, 2021
josephschorr
josephschorr approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzelinskie jzelinskie merged commit 698ec60 into main Dec 28, 2021
@jzelinskie jzelinskie deleted the more-linting branch December 28, 2021 01:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephschorr josephschorr josephschorr approved these changes

Assignees
No one assigned
Labels
area/api v0 Affects the v0 API area/api v1 Affects the v1 API area/CLI Affects the command line area/dashboard Affects the dashboard area/datastore Affects the storage system area/dependencies Affects dependencies area/dispatch Affects dispatching of requests area/schema Affects the Schema Language area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) kind/tech debt Addresses legacy code/decisions priority/3 low This would be nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jzelinskie @josephschorr