e2e: fill schema with many namespaces to span ranges #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/tooling
ecordell
force-pushed
the
enable-e2e
branch
28 times, most recently
from
6a4e5a4
to
4e1a7c4
Compare
jzelinskie
reviewed
Dec 28, 2021
| @@ -29,7 +29,7 @@ type Manager interface { | |||
| // ReadNamespaceAndTypes reads a namespace definition, version, and type system and returns it if found. | |||
| ReadNamespaceAndTypes(ctx context.Context, nsName string, revision decimal.Decimal) (*v0.NamespaceDefinition, *NamespaceTypeSystem, error) | |||
|
|
|||
| // Closes the namespace manager, disposing of any resources. | |||
| // Close closes the namespace manager, disposing of any resources. | |||
There was a problem hiding this comment.
Are we going to enforce linting rules on the e2e code? Because it's a separate project almost all the tooling doesn't run on this code.
There was a problem hiding this comment.
this is actually in the main module, not e2e
but yeah we should probably run the linters over this too
There was a problem hiding this comment.
this is actually in the main module, not e2e
Yep, the fact that this is a lint fix just reminded me that the other files are not being checked.
ecordell
force-pushed
the
enable-e2e
branch
17 times, most recently
from
f200428
to
c4cc7d9
Compare
in order for the newenemy test to work, we need to ensure that the additional reads for namespaces that have been added for namespace versioning do not re-sync timestamps across cockroach nodes. by first filling the datastore with a large number of namespaces, we can pick one that has a range leader on the slow node, so that future writes to the slow node don't involve reads from other nodes the core of the test is otherwise the same, though extra machinery for reasoning about range leaders was added
jzelinskie
approved these changes
Dec 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the e2e test suite after #332 broke them. Now that namespaces are read at specific revisions on tuple read/write, it's more difficult to reason about which cockroach nodes will be used for a given operation. This PR accounts for the additional namespace reads in the test.
What the test used to do:
What the test does now: