Versioned namespaces #332
Merged
Versioned namespaces #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v0
jakedt
force-pushed
the
versioned-namespaces
branch
from
fea1062
to
eb2e715
Compare
|
Note: this make may performance somewhat less predictable, but fixes a real issue with the rollout of new schemas. Now the schema version that was in place as of the chose query revision will be the one that is used to calculate the answer uniformly across all nodes. |
| func filterToLiveObjects(revision datastore.Revision) memdb.FilterFunc { | ||
| return func(hasLifetimeRaw interface{}) bool { | ||
| obj := hasLifetimeRaw.(hasLifetime) | ||
| return uint64(revision.IntPart()) < obj.getCreatedTxn() || uint64(revision.IntPart()) >= obj.getDeletedTxn() |
There was a problem hiding this comment.
Mind adding a comment here that the filter is inverted?
jakedt
force-pushed
the
versioned-namespaces
branch
from
c5d6666
to
289c471
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts all namespace operations to work at a provided revision in order to guarantee request consistency in the face of namespaces changes.