Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cmd: root programName and share ExampleServe #327

Merged
merged 1 commit into from Dec 9, 2021

Conversation

jzelinskie
Copy link
Member

@jzelinskie jzelinskie commented Dec 8, 2021

This change fixes plumbing a program name through the root command and provides reusability for the serve example which is used in the root and serve commands.

@github-actions github-actions bot added the area/CLI Affects the command line label Dec 8, 2021
pkg/cmd/defaults.go Outdated Show resolved Hide resolved
ecordell
ecordell previously approved these changes Dec 8, 2021
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzelinskie jzelinskie merged commit 50779a3 into authzed:main Dec 9, 2021
@jzelinskie jzelinskie deleted the cmd-fixes branch December 9, 2021 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/CLI Affects the command line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants