Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing should follow OpenTelemetry Semantic Conventions #1548

Open
jzelinskie opened this issue Sep 26, 2023 · 1 comment
Open

Tracing should follow OpenTelemetry Semantic Conventions #1548

jzelinskie opened this issue Sep 26, 2023 · 1 comment
Labels
area/api devtools Affects the devtools API area/observability Affects telemetry data hint/good first issue Someone new could handle this kind/tech debt Addresses legacy code/decisions priority/3 low This would be nice to have

Comments

@jzelinskie
Copy link
Member

What platforms are affected?

linux, macos, windows

What architectures are affected?

amd64, arm64

Steps to Reproduce

  1. Run SpiceDB with tracing enabled
  2. View tracing names and observe that not all follow the OpenTelemetry Semantic Conventions

Expected Result

The traces follow the well defined conventions so that they combine properly with other systems and are consumed properly by tracing processors.

Actual Result

SpiceDB has used their own conventions for naming events and attributes.
@jzelinskie jzelinskie added hint/good first issue Someone new could handle this priority/3 low This would be nice to have kind/tech debt Addresses legacy code/decisions area/observability Affects telemetry data area/api devtools Affects the devtools API labels Sep 26, 2023
@josephschorr
Copy link
Member

We should probably add a custom linter for this to be enforced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api devtools Affects the devtools API area/observability Affects telemetry data hint/good first issue Someone new could handle this kind/tech debt Addresses legacy code/decisions priority/3 low This would be nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jzelinskie @josephschorr