/
postgres.go
563 lines (458 loc) · 15.6 KB
/
postgres.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
package postgres
import (
"context"
dbsql "database/sql"
"errors"
"fmt"
"math/rand"
"time"
"golang.org/x/sync/errgroup"
sq "github.com/Masterminds/squirrel"
"github.com/alecthomas/units"
"github.com/jackc/pgtype"
"github.com/jackc/pgx/v4"
"github.com/jackc/pgx/v4/log/zerologadapter"
"github.com/jackc/pgx/v4/pgxpool"
"github.com/jackc/pgx/v4/stdlib"
"github.com/ngrok/sqlmw"
"github.com/prometheus/client_golang/prometheus"
"github.com/rs/zerolog/log"
"github.com/shopspring/decimal"
"go.opentelemetry.io/otel"
"github.com/authzed/spicedb/internal/datastore"
"github.com/authzed/spicedb/internal/datastore/postgres/migrations"
)
const (
tableNamespace = "namespace_config"
tableTransaction = "relation_tuple_transaction"
tableTuple = "relation_tuple"
colID = "id"
colTimestamp = "timestamp"
colNamespace = "namespace"
colConfig = "serialized_config"
colCreatedTxn = "created_transaction"
colDeletedTxn = "deleted_transaction"
colObjectID = "object_id"
colRelation = "relation"
colUsersetNamespace = "userset_namespace"
colUsersetObjectID = "userset_object_id"
colUsersetRelation = "userset_relation"
errUnableToInstantiate = "unable to instantiate datastore: %w"
errRevision = "unable to find revision: %w"
errCheckRevision = "unable to check revision: %w"
createTxn = "INSERT INTO relation_tuple_transaction DEFAULT VALUES RETURNING id"
// This is the largest positive integer possible in postgresql
liveDeletedTxnID = uint64(9223372036854775807)
tracingDriverName = "postgres-tracing"
batchDeleteSize = 1000
)
var (
gcDurationHistogram = prometheus.NewHistogram(prometheus.HistogramOpts{
Namespace: "spicedb",
Subsystem: "datastore",
Name: "postgres_gc_duration",
Help: "postgres garbage collection duration distribution in seconds.",
Buckets: []float64{0.01, 0.1, 0.5, 1, 5, 10, 25, 60, 120},
})
gcRelationshipsClearedGauge = prometheus.NewGauge(prometheus.GaugeOpts{
Namespace: "spicedb",
Subsystem: "datastore",
Name: "postgres_relationships_cleared",
Help: "number of relationships cleared by postgres garbage collection.",
})
gcTransactionsClearedGauge = prometheus.NewGauge(prometheus.GaugeOpts{
Namespace: "spicedb",
Subsystem: "datastore",
Name: "postgres_transactions_cleared",
Help: "number of transactions cleared by postgres garbage collection.",
})
)
func init() {
dbsql.Register(tracingDriverName, sqlmw.Driver(stdlib.GetDefaultDriver(), new(traceInterceptor)))
}
var (
psql = sq.StatementBuilder.PlaceholderFormat(sq.Dollar)
getRevision = psql.Select("MAX(id)").From(tableTransaction)
getRevisionRange = psql.Select("MIN(id)", "MAX(id)").From(tableTransaction)
getNow = psql.Select("NOW()")
tracer = otel.Tracer("spicedb/internal/datastore/postgres")
)
type sqlFilter interface {
ToSql() (string, []interface{}, error)
}
// NewPostgresDatastore initializes a SpiceDB datastore that uses a PostgreSQL
// database by leveraging manual book-keeping to implement revisioning.
//
// This datastore is also tested to be compatible with CockroachDB.
func NewPostgresDatastore(
url string,
options ...Option,
) (datastore.Datastore, error) {
config, err := generateConfig(options)
if err != nil {
return nil, fmt.Errorf(errUnableToInstantiate, err)
}
// config must be initialized by ParseConfig
pgxConfig, err := pgxpool.ParseConfig(url)
if err != nil {
return nil, fmt.Errorf(errUnableToInstantiate, err)
}
if config.maxOpenConns != nil {
pgxConfig.MaxConns = int32(*config.maxOpenConns)
}
if config.minOpenConns != nil {
pgxConfig.MinConns = int32(*config.minOpenConns)
}
if config.connMaxIdleTime != nil {
pgxConfig.MaxConnIdleTime = *config.connMaxIdleTime
}
if config.connMaxLifetime != nil {
pgxConfig.MaxConnLifetime = *config.connMaxLifetime
}
if config.healthCheckPeriod != nil {
pgxConfig.HealthCheckPeriod = *config.healthCheckPeriod
}
pgxConfig.ConnConfig.Logger = zerologadapter.NewLogger(log.Logger)
dbpool, err := pgxpool.ConnectConfig(context.Background(), pgxConfig)
if err != nil {
return nil, fmt.Errorf(errUnableToInstantiate, err)
}
if config.enablePrometheusStats {
collector := NewPgxpoolStatsCollector(dbpool, "spicedb")
err := prometheus.Register(collector)
if err != nil {
return nil, fmt.Errorf(errUnableToInstantiate, err)
}
err = prometheus.Register(gcDurationHistogram)
if err != nil {
return nil, fmt.Errorf(errUnableToInstantiate, err)
}
err = prometheus.Register(gcRelationshipsClearedGauge)
if err != nil {
return nil, fmt.Errorf(errUnableToInstantiate, err)
}
err = prometheus.Register(gcTransactionsClearedGauge)
if err != nil {
return nil, fmt.Errorf(errUnableToInstantiate, err)
}
}
gcCtx, cancelGc := context.WithCancel(context.Background())
datastore := &pgDatastore{
dburl: url,
dbpool: dbpool,
watchBufferLength: config.watchBufferLength,
revisionFuzzingTimedelta: config.revisionFuzzingTimedelta,
gcWindowInverted: -1 * config.gcWindow,
gcInterval: config.gcInterval,
gcMaxOperationTime: config.gcMaxOperationTime,
splitAtEstimatedQuerySize: config.splitAtEstimatedQuerySize,
gcCtx: gcCtx,
cancelGc: cancelGc,
}
// Start a goroutine for garbage collection.
if datastore.gcInterval > 0*time.Minute {
datastore.gcGroup, datastore.gcCtx = errgroup.WithContext(datastore.gcCtx)
datastore.gcGroup.Go(datastore.runGarbageCollector)
} else {
log.Warn().Msg("garbage collection disabled in postgres driver")
}
return datastore, nil
}
type pgDatastore struct {
dburl string
dbpool *pgxpool.Pool
watchBufferLength uint16
revisionFuzzingTimedelta time.Duration
gcWindowInverted time.Duration
gcInterval time.Duration
gcMaxOperationTime time.Duration
splitAtEstimatedQuerySize units.Base2Bytes
gcGroup *errgroup.Group
gcCtx context.Context
cancelGc context.CancelFunc
}
func (pgd *pgDatastore) Close() error {
pgd.cancelGc()
if pgd.gcGroup != nil {
err := pgd.gcGroup.Wait()
log.Warn().Err(err).Msg("completed shutdown of postgres datastore")
}
pgd.dbpool.Close()
return nil
}
func (pgd *pgDatastore) runGarbageCollector() error {
log.Info().Dur("interval", pgd.gcInterval).Msg("garbage collection worker started for postgres driver")
for {
select {
case <-pgd.gcCtx.Done():
log.Info().Msg("shutting down garbage collection worker for postgres driver")
return pgd.gcCtx.Err()
case <-time.After(pgd.gcInterval):
err := pgd.collectGarbage()
if err != nil {
log.Warn().Err(err).Msg("error when attempting to perform garbage collection")
} else {
log.Debug().Msg("garbage collection completed for postgres")
}
}
}
}
func (pgd *pgDatastore) getNow(ctx context.Context) (time.Time, error) {
// Retrieve the `now` time from the database.
nowSQL, nowArgs, err := getNow.ToSql()
if err != nil {
return time.Now(), err
}
var now time.Time
err = pgd.dbpool.QueryRow(datastore.SeparateContextWithTracing(ctx), nowSQL, nowArgs...).Scan(&now)
if err != nil {
return time.Now(), err
}
// RelationTupleTransaction is not timezone aware
// Explicitly use UTC before using as a query arg
now = now.UTC()
return now, nil
}
func (pgd *pgDatastore) collectGarbage() error {
startTime := time.Now()
defer func() {
gcDurationHistogram.Observe(time.Since(startTime).Seconds())
}()
ctx, cancel := context.WithTimeout(context.Background(), pgd.gcMaxOperationTime)
defer cancel()
// Ensure the database is ready.
ready, err := pgd.IsReady(ctx)
if err != nil {
return err
}
if !ready {
log.Ctx(ctx).Warn().Msg("cannot perform postgres garbage collection: postgres driver is not yet ready")
return nil
}
now, err := pgd.getNow(ctx)
if err != nil {
return err
}
before := now.Add(pgd.gcWindowInverted)
log.Ctx(ctx).Debug().Time("before", before).Msg("running postgres garbage collection")
_, _, err = pgd.collectGarbageBefore(ctx, before)
return err
}
func (pgd *pgDatastore) collectGarbageBefore(ctx context.Context, before time.Time) (int64, int64, error) {
// Find the highest transaction ID before the GC window.
sql, args, err := getRevision.Where(sq.Lt{colTimestamp: before}).ToSql()
if err != nil {
return 0, 0, err
}
value := pgtype.Int8{}
err = pgd.dbpool.QueryRow(
datastore.SeparateContextWithTracing(ctx), sql, args...,
).Scan(&value)
if err != nil {
return 0, 0, err
}
if value.Status != pgtype.Present {
log.Ctx(ctx).Debug().Time("before", before).Msg("no stale transactions found in the datastore")
return 0, 0, nil
}
var highest uint64
err = value.AssignTo(&highest)
if err != nil {
return 0, 0, err
}
log.Ctx(ctx).Trace().Uint64("highest_transaction_id", highest).Msg("retrieved transaction ID for GC")
return pgd.collectGarbageForTransaction(ctx, highest)
}
func (pgd *pgDatastore) collectGarbageForTransaction(ctx context.Context, highest uint64) (int64, int64, error) {
// Delete any relationship rows with deleted_transaction <= the transaction ID.
relCount, err := pgd.batchDelete(ctx, tableTuple, sq.LtOrEq{colDeletedTxn: highest})
if err != nil {
return 0, 0, err
}
log.Ctx(ctx).Trace().Uint64("highest_transaction_id", highest).Int64("relationships_deleted", relCount).Msg("deleted stale relationships")
gcRelationshipsClearedGauge.Set(float64(relCount))
// Delete all transaction rows with ID < the transaction ID. We don't delete the transaction
// itself to ensure there is always at least one transaction present.
transactionCount, err := pgd.batchDelete(ctx, tableTransaction, sq.Lt{colID: highest})
if err != nil {
return relCount, 0, err
}
log.Ctx(ctx).Trace().Uint64("highest_transaction_id", highest).Int64("transactions_deleted", transactionCount).Msg("deleted stale transactions")
gcTransactionsClearedGauge.Set(float64(transactionCount))
return relCount, transactionCount, nil
}
func (pgd *pgDatastore) batchDelete(ctx context.Context, tableName string, filter sqlFilter) (int64, error) {
sql, args, err := psql.Select("id").From(tableName).Where(filter).ToSql()
if err != nil {
return -1, err
}
query := fmt.Sprintf(`WITH rows AS (%s)
DELETE FROM %s
WHERE id IN (SELECT id FROM rows);
`, sql, tableName)
var deletedCount int64
for {
cr, err := pgd.dbpool.Exec(ctx, query, args...)
if err != nil {
return deletedCount, err
}
rowsDeleted := cr.RowsAffected()
deletedCount += rowsDeleted
if rowsDeleted < batchDeleteSize {
break
}
}
return deletedCount, nil
}
func (pgd *pgDatastore) IsReady(ctx context.Context) (bool, error) {
headMigration, err := migrations.DatabaseMigrations.HeadRevision()
if err != nil {
return false, fmt.Errorf("invalid head migration found for postgres: %w", err)
}
currentRevision, err := migrations.NewAlembicPostgresDriver(pgd.dburl)
if err != nil {
return false, err
}
defer currentRevision.Dispose()
version, err := currentRevision.Version()
if err != nil {
return false, err
}
return version == headMigration, nil
}
func (pgd *pgDatastore) HeadRevision(ctx context.Context) (datastore.Revision, error) {
ctx, span := tracer.Start(ctx, "HeadRevision")
defer span.End()
revision, err := pgd.loadRevision(ctx)
if err != nil {
return datastore.NoRevision, err
}
return revisionFromTransaction(revision), nil
}
func (pgd *pgDatastore) OptimizedRevision(ctx context.Context) (datastore.Revision, error) {
ctx, span := tracer.Start(ctx, "OptimizedRevision")
defer span.End()
lower, upper, err := pgd.computeRevisionRange(ctx, -1*pgd.revisionFuzzingTimedelta)
if err != nil && !errors.Is(err, pgx.ErrNoRows) {
return datastore.NoRevision, fmt.Errorf(errRevision, err)
}
if errors.Is(err, pgx.ErrNoRows) {
revision, err := pgd.loadRevision(ctx)
if err != nil {
return datastore.NoRevision, err
}
return revisionFromTransaction(revision), nil
}
if upper-lower == 0 {
return revisionFromTransaction(upper), nil
}
return revisionFromTransaction(uint64(rand.Intn(int(upper-lower))) + lower), nil
}
func (pgd *pgDatastore) CheckRevision(ctx context.Context, revision datastore.Revision) error {
ctx, span := tracer.Start(ctx, "CheckRevision")
defer span.End()
revisionTx := transactionFromRevision(revision)
lower, upper, err := pgd.computeRevisionRange(ctx, pgd.gcWindowInverted)
if err == nil {
if revisionTx < lower {
return datastore.NewInvalidRevisionErr(revision, datastore.RevisionStale)
} else if revisionTx > upper {
return datastore.NewInvalidRevisionErr(revision, datastore.RevisionInFuture)
}
return nil
}
if !errors.Is(err, pgx.ErrNoRows) {
return fmt.Errorf(errCheckRevision, err)
}
// There are no unexpired rows
sql, args, err := getRevision.ToSql()
if err != nil {
return fmt.Errorf(errCheckRevision, err)
}
var highest uint64
err = pgd.dbpool.QueryRow(
datastore.SeparateContextWithTracing(ctx), sql, args...,
).Scan(&highest)
if errors.Is(err, pgx.ErrNoRows) {
return datastore.NewInvalidRevisionErr(revision, datastore.CouldNotDetermineRevision)
}
if err != nil {
return fmt.Errorf(errCheckRevision, err)
}
if revisionTx < highest {
return datastore.NewInvalidRevisionErr(revision, datastore.RevisionStale)
} else if revisionTx > highest {
return datastore.NewInvalidRevisionErr(revision, datastore.RevisionInFuture)
}
return nil
}
func (pgd *pgDatastore) loadRevision(ctx context.Context) (uint64, error) {
ctx, span := tracer.Start(ctx, "loadRevision")
defer span.End()
sql, args, err := getRevision.ToSql()
if err != nil {
return 0, fmt.Errorf(errRevision, err)
}
var revision uint64
err = pgd.dbpool.QueryRow(datastore.SeparateContextWithTracing(ctx), sql, args...).Scan(&revision)
if err != nil {
if errors.Is(err, pgx.ErrNoRows) {
return 0, nil
}
return 0, fmt.Errorf(errRevision, err)
}
return revision, nil
}
func (pgd *pgDatastore) computeRevisionRange(ctx context.Context, windowInverted time.Duration) (uint64, uint64, error) {
ctx, span := tracer.Start(ctx, "computeRevisionRange")
defer span.End()
nowSQL, nowArgs, err := getNow.ToSql()
if err != nil {
return 0, 0, err
}
var now time.Time
err = pgd.dbpool.QueryRow(datastore.SeparateContextWithTracing(ctx), nowSQL, nowArgs...).Scan(&now)
if err != nil {
return 0, 0, err
}
// RelationTupleTransaction is not timezone aware
// Explicitly use UTC before using as a query arg
now = now.UTC()
span.AddEvent("DB returned value for NOW()")
lowerBound := now.Add(windowInverted)
sql, args, err := getRevisionRange.Where(sq.GtOrEq{colTimestamp: lowerBound}).ToSql()
if err != nil {
return 0, 0, err
}
var lower, upper dbsql.NullInt64
err = pgd.dbpool.QueryRow(
datastore.SeparateContextWithTracing(ctx), sql, args...,
).Scan(&lower, &upper)
if err != nil {
return 0, 0, err
}
span.AddEvent("DB returned revision range")
if !lower.Valid || !upper.Valid {
return 0, 0, pgx.ErrNoRows
}
return uint64(lower.Int64), uint64(upper.Int64), nil
}
func createNewTransaction(ctx context.Context, tx pgx.Tx) (newTxnID uint64, err error) {
ctx, span := tracer.Start(ctx, "computeNewTransaction")
defer span.End()
err = tx.QueryRow(ctx, createTxn).Scan(&newTxnID)
return
}
func revisionFromTransaction(txID uint64) datastore.Revision {
return decimal.NewFromInt(int64(txID))
}
func transactionFromRevision(revision datastore.Revision) uint64 {
return uint64(revision.IntPart())
}
func filterToLivingObjects(original sq.SelectBuilder, revision datastore.Revision) sq.SelectBuilder {
return original.Where(sq.LtOrEq{colCreatedTxn: transactionFromRevision(revision)}).
Where(sq.Or{
sq.Eq{colDeletedTxn: liveDeletedTxnID},
sq.Gt{colDeletedTxn: revision},
})
}