Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump buf reference to the latest proto definitions #36

Merged
merged 1 commit into from Nov 9, 2021

Conversation

jonwhitty
Copy link
Contributor

@josephschorr here are the changes to reference the latest proto definitions.

@jonwhitty
Copy link
Contributor Author

jonwhitty commented Nov 8, 2021

@jzelinskie I'm surprised to find the generated validators are no longer working. I updated the protoc-gen-validate plugin in authzed/api#15 but now it seems that the tests are failing because the validations are broken.

Any ideas?

@jzelinskie
Copy link
Member

buf itself reports its own version of protoc, but the fact that you're generating a different one means your buf version is probably newer than the one configured in CI

Try bumping the buf version in the buf-setup-action.

@jzelinskie
Copy link
Member

Ok! A rebase and regenerate should fix this PR!
Thanks for your patience.

Signed-off-by: Jonathan Whitaker <jwhitake@adobe.com>
@jzelinskie jzelinskie merged commit 0b30d66 into authzed:main Nov 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants